search

Cycling74 / min-devkit

Tools, documentation, and reference implementation of a Max Package built using the Min-API.
MIT License
156 stars 30 forks source link

update min-api #186

Closed sbl closed 2 years ago

sbl commented 3 years ago

closes #185

As a general suggestion, the CMakeLists.txt includes a call to update the git submodules https://github.com/Cycling74/min-devkit/blob/master/CMakeLists.txt#L17-L22 which is likely an unexpected side effect (this has caught me already a couple of times). Maybe it would be worthwhile to remove this from cmake - I'd imagine it would be up to the respective package developer to update their git submodules.

sbl commented 3 years ago

added https://github.com/Cycling74/min-devkit/pull/187 to address the suggestion.

isabelgk commented 2 years ago

Addressed in ac82645771cb41f1a7b7081ad8dc1160559fd464