Cycling74 / miraweb

MIT License
139 stars 14 forks source link

Update to React@15.6.2, migrate prop-types #135

Open zacacollier opened 6 years ago

zacacollier commented 6 years ago

This PR addresses #94.

fde31 commented 6 years ago

Thanks for that. I assume you went for React v15.6.2 in order to avoid the changes in the Lifecycle API?

MiraWeb uses React mostly as a shell so it's not too deep wrt usage of React Components. Did you see any specific issues that are worth considering? If it's straight forward enough it would be lovely to see an update to an even newer React version, which shouldn't keep us from merging the PR at all though. But guess at this point it's not worth triggering an actual MiraWeb package update for that unless we can also make some progress on some of the other open issues.

Let me know if you got some cycles or if you also have some questions about the codebase in general etc.

Thanks much again!

fde31 commented 5 years ago

In review for 1.3.0 Release. Assigning milestone. Sorry this has been taking us a while. thanks again!