Cycling74 / miraweb

MIT License
138 stars 14 forks source link

fpic: does not scale svgs correctly #136

Open benbrackenc74 opened 6 years ago

benbrackenc74 commented 6 years ago

Check this patcher in Max and in MiraWeb:


----------begin_max5_patcher----------
1731.3oc0Zs0aihCE941eEnncdKSJl6oqVsZWs+E1mlcTjAbndJXiLl1Nyn4
+95K.ARAhSaIclJUfXaNW9NGe7wly2u9pUwzmPUqrt05SVWc02u9pqTMIa3p
lee0pB3SI4vJ0vVsuDmrZstiRHO4NLIaGCkv0DA.1Xu1x0KPdyIDrwesEv2a
is0madIRcAlji3JxAZojfnRpey+VgXU2DiHwLXx8HxM+C8QRNElVcSILC8Qv
lpGxZ4OrlS2i48Ijf5zZ9yHOCUgHbHGSImkvhSUhEM9KeLpkqZ5y+ZIRSkUe
Ay2U.4Lr.2ZeQTQLR8t.4u+w0WKur1PLNtlyojV98.jQfEnd87Ivmm0D3nzG
fu5lW604s.wYIzbJSSB6Mf.uP6f0hmBCEOBjOEEF44JdBLjVmCdeBIqDxDZJ
Gw1gHv3bTeZ1yTDNooHFRxNXDhywj6GnVQairc2pTK4CNxmbChBbBGpVUvGP
o6fbgQU.4nCOU0X1ZraRqSdMhtus4116qKU2QY7IMgGo10EMpBc+9UqE2Hc5
yfQ1pzNizWNkjYF+JD9cJPdistSkmZ6syzskfdTXcZsMbzSJy9pRKZIh72L5
ih41mLzgi2V4Mfis5WNS4257xmvOCK54jELoS1pd9qBs.wN1mXONG8fHNFVZ
75DJQ7pxxdMOzco.9EsaZTmYRns5lr6Zhgd.299GZExDXIWnk0LsM+o.uCV6
BZJhQpwcQiT1zqaIXG1XGIgiHUvv.W0jSOW+CfyyhQbXxzyeBb3sPoXtzR+x
d63rbpXgfz9Z7JoCElz2HOn6TzdXcNe2dJgWg+lNLhLzyH8uGlfl7k6lD8WL
LLuERWkwvoThTHFXdkM2xNAdpBxAF.fpQPfki7xBWNgoXhNqDJYcULjIs9Mw
Eam3uhSo4C6p68xQ64McWhIjiPQNsb5NY3r6l4ciohNKli1pdp1USz8tSDlf
uSFWc33f44MwMFR9mfDrXQUDGqMAN1ccpWa3tpDFMOef9p64gQ5IULwIA8HN
kemhQ8cFDCGW15DspyJmhyPU7gswgYUCaoh+UMn2qo53l.C63nhxbgVLb.CR
5peTf9QXGz9bQZGFskakakjifr98NRzVWecVOa0Sz2dbnvIyTXjntN8Y03Qd
MhcirD+DQfEKLpURqO2NrlUtZWv5k.qEnpJQRlihqYH9in3JYrHdoX870VhV
tiVoiQLOVC7rUoVZqV9ADANMX6LIXCNMXaF+5g1.v7v8aJJOiyaoHmeqJKrE
1LD0Qqg9gmFPceC.z4Y2H6U3cFNYBVirZcRsjtsF5oF3p7b.QuFf00bO0442
HYkMcbA0+WJDt.yfazqNaHx5p1BTvqJd6YDBXV10CWctfdrC1d6T3kiNpEHb
7sJ9FCWlvsw1bp8Dno2rvYytTeCgTELbJD0ErwQ5SnO0C61qSCo1uJH0D10e
MnslfY8FRBsnPv2AoVonIIEovLmKSL.tUrU7Iv9.0lA7c0m2zBmqkALqOtGd
Zbe8R3yNCjJOvOMiMJlpxCKv9BERcNt0GW8uvw.lAO+V9FFJyHez1LzseM4n
ZrS57bqOZ5c5E9uTnYUICS36sp9pTmsDaSt71at4CU29gza9SYRV+wGRML+0
lidF.tPIvNO+5g2d+bjAaGTi3Vca+xJgRHBUSnhVvGf3b4pwVP9sCLE8oWNV
LdZsdwBGy1XbCT4q7SGbNXusaVyL90yz3dAMMZxa1QI3J1UuuYIVLcbXaiAr
4YW+PGqNmjF.WnyS32+OlXrV4vZRxcw5CG252.uTuVc3TWWUBr.WvB6zZD65
aCrufNsljLrVAtPoBa.y5gU9u04AOlK8gyjV5kMwgQpvMY+iC5UzZVRqb0br
GVCUqTTEGS5Ng9O0s3xQiixR0eFEyl9sTBl6zBl8hHXgFJX.83VLY.7NKCAF
hCQKrL.LTF.WRu2yQvbtjdu9l58FtflMOSEBOMLtHBgqgBwymuO3ahF3u9nq
aWHA1wXXaIm16XnPDrfxf7bmd+QBP343FunRA3cGK7+ovhX7LD6kTJ.FJENS
JDMM1VyGM01jtdClovlNquKdVNMFl27Uu6pZhQ9r4u7pK5TEE2IqrHfm5qKs
Ezd8mgBhadAyv5gyY6u9ED2EsZ3V7RgS8cA2yNTZ.yTqr5OQmSPzlvsh+bih
.dfsh+EV.o2frQ6HOuPm.+.mwcZsG06y1nxe8Ex+QNgEg2Vx8YLZMIcfmZFg
J3ZNN49iqHVE0FtETM7dbbxFPd9MPMS1CMI98Lyno7wYqgLxd.iz52Q08mjG
GUueGUqeOuN+ltF+Nt99Db9GW++PBGcKb
-----------end_max5_patcher-----------
fde31 commented 5 years ago

Hm. I assume u mean the fact that the SVG gets stretched compared to Max' behaviour? Looking at the code I recall that Max is rendering the SVG to a PNG and sending this data over to the client. Unfortunately I didn't see any hint that MW itself is aware of the original image resource dimensions that would allow scaling accordingly. @starakaj any thoughts?

starakaj commented 5 years ago

Interesting... I can't tell instantly where the problem is here, but one thing I notice is that fpic handles image sizing differently depending on whether the image is .svg or not. In fact, the "Fixed Aspect Ratio" attribute for fpic doesn't seem to do anything if fpic loads an svg image. Long story short, this is worth investigating, but I'm not 100% sure where the problem is.