search

Cycling74 / miraweb

MIT License
138 stars 14 forks source link

Max 8 compatibility: live.dial, message, umenu, meter~ are not rendered #138

Closed benbrackenc74 closed 5 years ago

benbrackenc74 commented 5 years ago

Going through the mira.frame help patcher, the following objects are no rendered in the browser:

Haven't done any excavation, and there are not errors in the Max Console or browser console.

benbrackenc74 commented 5 years ago

It appears that in the case of message and umenu, it has something to do with their gradient usage. Touch any color attr and they will get rendered.

In the cases of live.dial and meter~, their constructors and paint methods are never hit. If you put a post at the top of live.dial, it will post, but it never reaches the class definitions, which makes me think there is something amiss deeper in the registration of EventEmitter or something.

starakaj commented 5 years ago

Thanks for reporting this. Paint won't get called until all of the attributes are set, so I'm guessing something has changed such that Max 8 isn't sending all the attributes anymore.

starakaj commented 5 years ago

Alright.... I'm having some trouble building miraweb.... but I'm looking into this

starakaj commented 5 years ago

Okay, figured out the building issues. Not clear why they didn't come up before, florian thinks lerna might have changed somehow. Anyway, the issue is exactly what we thought: Max 8 no longer defines certain attributes. Making those attributes optional is an easy fix, working on that now.

starakaj commented 5 years ago

Panel is actually a problem child as well—anything with a gradient is gonna be an issue.

starakaj commented 5 years ago

Alright, I'm gonna close and make a new ticket for meter~. The issue here is much more complex than for the other objects, and is gonna require an update to the meter~ object itself in Max. Basically, the update to multichannel meter~ got rid of a pseudoparameter that would update whenever the object redrew its levels. So we at least need to update the object not to break old functionality, as a spotgap, and then we can think about maybe updating meter~ for multichannel, which I'm sure some people would be really happy about.

fde31 commented 5 years ago

Not sure why this was closed as this hasn't been merged fully yet. So yeah, reopening here. @starakaj I assume this is the work of PR #140

fde31 commented 5 years ago

merged in PR #140, which leaves us with meter~ from #141 . will close this ticket. @starakaj please consider working on dev for these kind of things or on a feature branch for proper PR's for the future. Thanks.