Cycling74 / miraweb

MIT License
138 stars 14 forks source link

Miraweb + Live.grid: #184

Open lysdexic-audio opened 3 years ago

lysdexic-audio commented 3 years ago

Describe the bug Updating the columns attribute for live.grid using a message crashes miraweb client

Attempting to slow throughput with a sizeable qlim / speedlim between, the redraw does not clear the old UI for [live.grid] making the UI unresponsive and unstable - eventually crashing.

Appears to only be with Miraweb and not Mira (iOS)

Expected behavior Changing the columns attribute for live.grid should not crash the client or break the UI

To Reproduce

Demonstration patch with instructions here:


----------begin_max5_patcher----------
4635.3oc4cs9ababD+yx+UPbn4axW1GbWR5hhh59vsnNoAINHnvMPf2cTmXD
Oxqj7jrbQye6ceQxkuWdhTRF0.9D0xWyieyryL6rm9Ou5hUaR9TP1Jq2X8Qq
Kt3+7pKtPLDefKT+9EqN3+osQ9YhKaUbv8Ia9kUWJOUdvmxEC+uiBOXAA.Pw
YB2IFmcsuFVLV7oCgwQA4hmDpZvjS4EiBUidzOe6Mgw6uJMXatj9fDzZaJlh
ccH11DOL16RKnGcM4RKh8ZvkVHvZf0OqdBxGZ9CGCj29pUV+L+L+2W8J9GWZ
H+FEdWvZAapdt24mF6eHn6SdLMHKHN2OOLIVmzQXN8AABxDBAsYDrqFsqI7P
tkOa+T16MOH8pfX+MQA5hqZRVnlxIIV7j9ov7ardOmZ2mxd3pK35j37rvOKe
RbJrMSz3knooPZOjRAxeHMzOZ0.5vIJHZqDuTnHaB+37G6ZayhY92Er6J+77
zvMmxCpNJSoyUJctdM5TPx0ECWLdc49oCJ5fc0PNsv9IpjdpcwQIw66EnT6J
Ov.bZx4ZmK6ljzbydLERIj7TBbdwOlHneaxgCLDPKq7uM4dq7zGrtuS3TTXb
v1jSw45viMm1z.qxeZ+xor7vqC21Bioi7cVMD5tNZDzOlCYiW6fgtPOriCB4
QodkHPWW9mXLGxcFxodbFt2OOnC+fHxL4HTZDgPTwO73N.WBWe8vco9w6RXN
6qzO57HZd3QhT+fk+fRF28dHG2Mir4mir1mlb5XWLIXBLIZ.lDR35NLFvYOa
GClC6xYVYd5yg8nIgSAshGUShbjLIZblbie7dNiV7y4VyFk3uS9rayz1Svmy
3vWjjcIXCY54jKYyheLHdmkXB9N3T77voroqaGTlTWK+bI7Lc3TTdXVT3tfz
tBKqiS2SfYXxZr3eHB1kBrcr4HUOAREBWSbAXjKhXCwPLgwYbWtkLSQnSHmN
DuHSBaiMOKSjFtILJL+gQimaZwkskEW1N+b+yP+g7bMSBLR3YYLRJ+g5rLaL
Fqoh34iVBHByAjtXcNCYqVTXswECDq0HWbASCd7QawMYC1E1Nbq6C1jkr81f
bKlxjEaEWwa4emeXDGHY4m+FqaxyO9lu9qgdn0Pp6ZlB6Mt.W5fgjUyVX7qn
BqX6oRyRF3AUXmfc5NwEr8PV.fGOP2tHBy8aShRRKvSHDlfX.U1Q7CrEGwRS
D3x.ZZjZ+dsgxnB6h+5Dvyme5xlX+MIoLjSMJCRsc.TN833vNDxOx0w0FCUT
1LFodZv0Lg3MVcBgBiuNYYPHTDZsCKjFluBdjMPDUFfilHrcBA5QVAW83AFC
jK.EqnOnSK56Lj9LuR7Lr6XJH4Y9H7mGYBHhmHzVnJtH6hO6xhx6rqDfYxMX
2FTiBaKtMFP41Z2oqGa1CgonC+.D+HL0kxlvbLSQJPJWpjHMjK8E.0Bm2ex0
Wysy4hwQS5uIF3LS5evGyLlzeewQZkvhi7soI2mMZ3TpIHfNToxqc.f5gHMb
VTSCyNf2bhaeDSKLz1n.+zU0wkAoMQLWGFEbWPZVcB6hU9GOpMbcvzA+eQZW
3VpDY7rbnJHPZvcgE2e0E5mxXsbFecJUhH9D0tBKbHgMOS7oPwSp.ETPRBsK
GIkczeqBNw.AEmVqlB.gTxUn3nXgjyl4DuTXwcKDwmIYmlKVlHjgMBiapqJO
8tfq8YwQcUsJMhV244uVQgcdxNqv3Eq3keJIlSD0zD7gKdc7BGKwA5Li3Jh8
O1wMyvlLwROmLiwjmx13mxUTJWunhSlmjDU+Tk2WTv04pSeLjMQbcoXdxw9O
YZ39aF3d2jvN4ggd1hyjc0oX4YuhgIxuh6fr904GEobAT+w+I+3vC94A4gRU
.BTdR4zO2jsMMIJpF+JOyccblcLL91f6C2kei3EoCFXWd3wBPzpRs7tv8AY4
0GK2eeV8QJS0PanSaT1vWkGb3XDutb0t.l0QXVNye68YpKr.noK.pVgDcaZc
+o0FeH+p08slaEYI84ncVMWjN5i20L68m+Wu46QTUMTZh6IqjnloQug4V3br
3xTy0TLEy4HZX9kx72GzorYePdYvqGYyGdoEajaRxjtB5VdAg8JvP8JvfCKv
f1.Qnh.nL2.ngRrYUPM.Fh4X+VqLqPqvdDJt8JSvORYBRJSHNuvDIorWcfUA
Vwhid5Q1POCYC1L7BUtRWPWysvzpt6xKjNDl5uVNcVOBGzY38wPiIrHcGp2y
AvoVRas3Y6U03fdqbwLJTPReJPmtS0Yz5EOSxEAmzmiUudwBfylswv0HQt3x
U5o3Si3asKonDH5SrKH+3cAeRK2nk1fJ2Zi0l9jeKvL4xEESt1Bx.1G2Rp1R
q7T4oow5sz6BMs.9YDPKJXBBmmJgxmiVmFzqHw9LhiwH3RQbefILqzSkHI6X
ZHKMPqrG3rUQos+pr27U695eOeR7e2WsqGAl8xEiisLdY3Ks39JkVA4VluPA
Boo9yqqp61pT9yeT0EognjtDA3rV8FdBjtxGee1fmgWIfQLM1VzxF8Li2nSm
AehR.629uRYWqUj+o3s2rQV+OqeCbpfmxx7MinGouLLVDwDDCeN.OCEtDY9i
VRxxKdrRcAtppZFWe2SsPDjL+7cK5xRNktsftTYkZUm72EjkGFWVCwOV5Yuw
0IVXMyMDVJBC2OgAVDBywPBCJutEiFfOyz.0P4f6BSCPCoA3SI5cJDF5oD8R
LE85rfpMaSIBaoXbQHBrgDQa68ZKtJkbYiO8VHBFYrXaIM6QFRDzEjF3kA44
WR.clBLdQoB3ytrf7hPiXrEBXIoBngTApWhPMXwBHqZiB4JhNPOTLoUtaeTx
F+nFK2VWKr27u+E1FEt8Vq7DQKMvyZ1pHuFV9x42DlYcvmG3cvxzcTDOYEOc
UKHMsZyGXRyQAW5liBHIOpSKxaA5MJyZkDGgnxCV7YmaQp+epwnTc0hbM25P
t7ESeQMGME0yTGQo5rdlJ8zg3rNZt9Yp256dGOJaqdOzhtiG2osO9ZsiG0OY
eMVeGsUtmpu5Ee121cbgMkQSqS36kj6rR4WGk3mu5InQ1apE5zHhZW1ZM8aG
kkGbLaHyntLEOEGV0X+yPCvG0bmDpi33iCOmswA1l4glR8n.0+PbMo8ZGHfh
wLkrCFf3y2gcVaytRaB0lB7HHGZoJ7fOSk8IdK1UaOLvDZ08mylrj681l.Xd
1EsbNU3hGUbhNGB1WmySlrUPAtlGNSMR8n+1P9D.ZcZEadrVb.FhcPDaO.uS
4cbuz3gzlrxHCPpZzaZLYpml.TMinICoKBK7Gqukb1ElJWNjqtIf2GcBByYM
XhaHFJRtpYtqgLjhqmsmG0AwQTH7ZBlRATOOlmYOOh2H6Nll+evcLfPLaWH1
uz7gHkO1RIfdzeG7SukApXtBB+bBSmEUCyLm9sBi6nSI60wllSfAbZ02UUHp
wOdWRhti45zpVMqOWOHa9Z4HCS0FyBY1FyfF.fKwigIXlHXntQB+4xx63J+r
ipGQgJoZDZaWBcusDAmUj+a72dKemsFuq1tx1eSo78G+aVE6eDlRuicUe393
DlHfmM0HgvXp3QSEIjU0WpAoFqY9vJ8V67f0SCtuTfIUU3qEzvzWD1fWjVYG
N62imIuGvLvPHieSOVVB4ZpR5Q+lHF7lDS4Zoalt6XRXbtBAx6WMdu.PPEAB
15WbUagauVycPbW+n4AjIRqYQu.LAAfFRXQPpEyGV0Oa09khdPoKgkm8iWXY
h9t10TeoOVzWLrm2L7Q8lglfwQnY.e.I5U8cIQh0qoZehy4vCAD+nw7chkkM
Wubw5q+KKqA.DXjGuVRN4DuM1ES7WRicuTictT6csT+6Xol6VIQglk6biFS1
WeC+71jncEMRRw9BptTPeGFw2NSZwbou+g9n5AZwehk0G4Rk7MkEEUysQhbi
fW3cPWeTQhm1El7ChVo9puIH9zPz4l8WGFEUFkudzzEgupVmux8vUsc2rmMD
VkKln5iXdb+D8EiQdOvhaxlmxlH+IaQ1ShibQXBtVFbpaCU8t344IdCko0h4
CUu9lL0c7dU78NZammioI7l1qHyi0L3cw0eJOYep+tPUqn.pEm9iTY7GYZ6z
jHUQMVUsklz0A0jo.HzQtBp3xzZc3ac7F0w0e6VFIU+VEBPUMeY2OO4duZ6l
ay3FXeby6Jy.oO3T8BQ3.HtBFvVTlAA4oz4iwJ7LqI001DY9jSlc5U479Sa8
GhcpQQ1NDHVPQHOrqm7HBDTJg0JLq3F4IaxbcETBf4UagJusBK.TWEn2.axR
7ZOlkFZpT2vzszbrRw0wJHzzvjxq+gnhR7+4HOpkRd9rK6d4O7.1PGQ0FX5F
aGAY3Zi7jfHBsO+u+C9Zu8C9wYV+PvgvMR+v8iKwE0z.aWv1E04PWGlEDIKy
Qsa1AIyxjuXMNHo6NW..1n3ar68Py2qiKSzJ0M.nqq7HFIfPyoAw23mm+HlV
qXOy9wpT+djDz28GxuRba.isS8T9J4J8hUDCnVgKirSkdQUe.avhZbORuXe7
cinFY.kO.OFPjHsMXlTN3urMzM91VZKcIC10QvQBzZPa6wbjMKH5Ojx70Hu6
gfzc90R3G0x0oD9N0oWlfWSG6kwZ4YC3iKWYbLWvHtM48RNmvNY3CmmJT+vz
QE82D1+8m1Dd6fvdSANcMsTas+rXj7Se3uXr+dnXgFD96KWXFmhbP5GO51rw
FjsNSM4B6IKljFpBjlKwY98Pp1a7YGMaTrHO64Q0W6pfY1hBoqiM0yScDvaP
m3+0G1klrOH9CBA6.fZBfYpKy2ffgx2CSMh7FGSaSgPfLqTOD0VHpHdPWG24
Dh6u91ASkpaLobs0Ddo4SLAkqtFK0JbSL4jlYqmYLi24GEX8MIwIKWLwCwQv
diubtzBhkXKbq4IAV1pTsOZNCtzaTuS89fNyR5TEbH1SVzA1Ap.o4CQvyiWk
5EHnbpm1GcV9hFzkiYbVSqf2EDGbm+fF.ihJlSr5a050rQQrp7PbK0N.0QyN
Y8mJ6+mWPD067Ci+UiMtwUc+XqileRK69Plc8PDWKjFTYqW8whPSnWTD0eW+
a8TyvVMnlt8FzqCztmmxTO+cFQwSo+g2GraZ1gcIC5hKnKSr9Jx9aD81117z
nGA0OqDDuId90ITs6Qce7RAg7sI6BxL1qngyQOP.LO+L7jbg.VXf02d5vlgI
lt7.0dRyEfz9tvs4iKqd10meGuCyxewEswOrM4Xf4gaTs5mdhtEtyX4e9Dxe
veyrmVTWHmQ8uLqLEKurMSN.5timn2EfcorN+PxddVPyV3rCnT5sPoyLK8iG
FoAEdBCz7m7uK35jzC+5rKgmdDkf0jYh414md6qi4Ma9qEERXrEcntsoYq3S
Oknvtzd1ortxkUXVtoylghnNVw8m8hVL6EPsdQK5vsxnKo4rfTBSuy7EY0l2
kJxsQRgznXWXLqKxJXZEB6EQc4+xd4UM0len9X6YdMV+E014F.TaUq43QgLu
wH7VSFAzVIFZcP+MUvfUZGLik.1rWyWDdSahR2DEvB9S1vOuMI41UyFjKL91
IM2JU8WAFkeKrZcP5co5M356CqU+qlE3fPrpkSUtMtzOZFVlAy4lmvo2eY3P
sKukiqy6N1RCtwNKw2.21rXlbqr5B+DueretC6OhGT73IC1rJe.OaUye54gc
cTG43ZPptzxneIktSKf0yGeI6w3p49dw0f5RB7sQmBdMbRK0.uMycTcMPkrz
agjf7+HyDOYJ7oTG+Geve5DH.4QrUeOgfwHYKegfL+9yOA9tzffyfBERuxZh
A0+pHYFItuOX2jIMmxodfkgFAT+Idatou+YPTTx8udJlwn0.hG.3NzbJtHhr
eXbbgth4SY2CYdC.uFCf9RjAD0n+cLmdSGhTlhNg+sqfr0izi5XVHvimRONb
s.6M0amxtFrZWY3p1tECT7YLvFn9KYHAPU+kLzkPQyZaQkFrMH7tgWdptvDi
sSSlGhSF8BGVXbkRn1TprhdLmrNpNrkv2fcCJseZPQYAw6xdo4cN2+3XdLzB
O4894IVuW9kowb89yxCt9TTT9zp2to0DqYiP5RHPYwQoXGrrQboLvKcdEpRl
5ogmPr7ajsjHtDnfQdXO2WJAIy+lj3E0Nc4ddJQObVNzmP2cVwRX5nEN.54A
ntJWo1pEOkB.xcWnWeIL7mBSyev5OuOY0HIoN5Ncb5BV4lFtm+NC9p+6q9e.
zYP7m
-----------end_max5_patcher-----------

Additional context Javascript console output at crash (chrome) `

I get the following in the Javascript console (chrome): PixiJS 4.8.3 - ✰ WebGL ✰ http://www.pixijs.com/ ♥♥♥ app.js?08c7e25c19e7da79d441:41 Uncaught TypeError: Cannot set property '_needsRedraw' of undefined at t.value (app.js?08c7e25c19e7da79d441:41) at t.value (app.js?08c7e25c19e7da79d441:41) at t.value (app.js?08c7e25c19e7da79d441:1) at app.js?08c7e25c19e7da79d441:41 at Array.forEach () at t.value (app.js?08c7e25c19e7da79d441:41) 85app.js?08c7e25c19e7da79d441:41 Uncaught TypeError: Cannot set property 'cellStyle' of undefined at t.value (app.js?08c7e25c19e7da79d441:41) at t.value (app.js?08c7e25c19e7da79d441:41) at t.n.emit (app.js?08c7e25c19e7da79d441:11) at t._onParamChange (app.js?08c7e25c19e7da79d441:36) at t.n.emit (app.js?08c7e25c19e7da79d441:11) at t.value (app.js?08c7e25c19e7da79d441:61) at t.n._modifyNode (app.js?08c7e25c19e7da79d441:11) at t.n.emit (app.js?08c7e25c19e7da79d441:11) at t.value (app.js?08c7e25c19e7da79d441:61) at t.value (app.js?08c7e25c19e7da79d441:61) `

Desktop (please complete the following information):

Smartphone (please complete the following information):