search

Cycling74 / rnbo-runner-panel

Web interface to the RNBO runner
MIT License
9 stars 1 forks source link

WIP: Parameter & Port Meta Editing #141

Closed fde31 closed 3 months ago

fde31 commented 3 months ago

WIP work for meta editing of instance parameters. Wanna check if that does the intended job @x37v ?

Think for ports it's gonna be pretty similar, we just need to drill open ports into records as they are currently simple Map AFAIR

x37v commented 3 months ago

Another thought.. I originally thought there might be an "edit meta" button next to the parameter.. I get that it would take up space but it might be nice to not have to navigate 2 different ways, you could use the sort and search to find a parameter you care about and edit it. I wonder if the "..." actions menu like sets and presets could work for that? Eventually I'd like to add "map midi" into that menu if we had it..

fde31 commented 3 months ago

See comment above about the restore value. Other than that this should hopefully address most of your concerns? Also note that "remote updates" with a "dirty input" are triggering a dialogue to confirm the overwrite.

Ideally the concept of the modal should be ez enough to apply for inport and outports as well given that it's not really parameter specific / bound anymore. You ok making the changes need to expand this, esp wrt turning the ImmuMap<string,string> of [inport] and [outports] into something like a MessageRecord to support sorting metadata and whatever else might come?

x37v commented 3 months ago

You ok making the changes need to expand this, esp wrt turning the ImmuMap<string,string> of [inport] and [outports] into something like a MessageRecord to support sorting metadata and whatever else might come?

Yeah, I'm happy to take over. There are a couple of minor little editor things happening that could be smoothed out a bit more but, this is really great!