Cycling74 / rnbo-runner-panel

Web interface to the RNBO runner
MIT License
9 stars 1 forks source link

Feature/midi map #145

Closed x37v closed 1 week ago

x37v commented 1 week ago

From a general UX perspective I'd be happy to tweak things a bit as I think it could be a more more obvious once one is in active "MIDIMapping" mode. Also I suspect we'd ideally like to disable changing parameter values from the UI when selecting a param to map and just maintain a "selection" state?

ahh yeah, that is a good idea!

Another q would be - should we auto disable MIDI mapping when the user switches views / tabs or at least prevent direct navigation with a confirm dialogue?

Yes, I was actually gonna ask about that, I briefly looked into it but then maybe i lost track

fde31 commented 1 week ago

From a general UX perspective I'd be happy to tweak things a bit as I think it could be a more more obvious once one is in active "MIDIMapping" mode. Also I suspect we'd ideally like to disable changing parameter values from the UI when selecting a param to map and just maintain a "selection" state?

ahh yeah, that is a good idea!

I can just clean that up as part of polishing the UI a bit. Was thinking we could just follow the Max color scheme a bit here to rely on something already existing.

Once u took a look at the suggestions just throw it my way and I can take a pass.

x37v commented 1 week ago

the Midi vs MIDI thing exists elsewhere too, I figure maybe we can do a cleanup pass after?

fde31 commented 1 week ago

ok tweaked things by

Also noticed that our parameter column layout was broken, so fixed that.

Thing one issue is left if we really want to allow "any" JSON input in the meta editor or if it is safe to assume that meta should and will always be "" | Record<string, AnyJSON>. If that is the case I think we can further harden the validation of the JSON input and the parsing functions on the ParameterRecord

fde31 commented 1 week ago

Gonna break out the remaining tasks / discussions into tickets