search

Cycling74 / rnbo.example.vcvrack

An example of using RNBO exports in VCV Rack plugins
GNU General Public License v3.0
27 stars 1 forks source link

make dist not working #4

Closed michelezaccagnini closed 1 year ago

michelezaccagnini commented 1 year ago

I cloned the repo, did export RACK_SDK=<SDK dir>, MSYS is installed (I have successfully created a VCV module). I get this error

make: *** No rule to make target 'build/rnbo-export/rnbo_source.cpp.o', needed by 'plugin.dll'.  Stop.
isabelgk commented 1 year ago

Hi Michele,

Do you have a file called rnbo_source.cpp in your rnbo-export directory? If you exported the C++ code from RNBO with a different name, I believe this is the error you'd see.

You can set it here to make sure the naming is correct:

image
michelezaccagnini commented 1 year ago

I don't. Oh it needs to have that specific name?

isabelgk commented 1 year ago

Okay, in that case, try clearing out the rnbo-export directory and re-exporting with the name rnbo_source.cpp.

isabelgk commented 1 year ago

it needs to have that specific name?

Yes, currently that's the case. I see it's not called out in the documentation anywhere, so if this is the fix, the docs might need to be updated.

michelezaccagnini commented 1 year ago

Ok, it worked! Thanks so much. This is a great tool...

isabelgk commented 1 year ago

Wonderful! I'll update the README to clarify this current requirement.

michelezaccagnini commented 1 year ago

Good morning Isabel,

I created two issues on GitHub. The main one for me would be how to consolidate multiple modules in a VCV plugin, since they need to refer to same-named “rnbo-export” and “rnbo_source”. I know I have to change the json to add different SOURCES and rename things. I think this is related to the first issue I created. I would like to submit this package to VCV library (it already exists as a package in Max), which brings me to the second issue: how to credit you and Cycling74 in this VCV release, whenever it happens. Thanks for any suggestions!

Michele

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows

From: @.> Sent: Thursday, June 8, 2023 9:52 AM To: @.> Cc: Michele @.>; @.> Subject: Re: [Cycling74/rnbo.example.vcvrack] make dist not working (Issue #4)

Wonderful! I'll update the README to clarify this current requirement.

— Reply to this email directly, view it on GitHubhttps://github.com/Cycling74/rnbo.example.vcvrack/issues/4#issuecomment-1582618449, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACXV4XIFX62TRL4KSBY2TB3XKHKLFANCNFSM6AAAAAAY6OMM2I. You are receiving this because you authored the thread.Message ID: @.***>