search

CycloneDX / cyclonedx-core-java

CycloneDX SBOM Model and Utils for Creating and Validating BOMs
https://cyclonedx.org/
Apache License 2.0
81 stars 61 forks source link

Update vulnerabilities to use new Tool specification #437

Closed shaikhu closed 4 months ago

shaikhu commented 4 months ago

According to the docs, since v1.5 the Tools format has been deprecated and a new format recommended. While the entity Metada has been updated to use the new format (new method setToolChoice), Vulnerability has not. This PR adds a similar method to Vulnerability.

nscuro commented 4 months ago

Thanks for the PR @shaikhu. Can you please sign-off your commits to make the DCO check happy? You can find instructions on how to do that by clicking on the Details link next to the failing build check.

shaikhu commented 4 months ago

Thanks for the PR @shaikhu. Can you please sign-off your commits to make the DCO check happy? You can find instructions on how to do that by clicking on the Details link next to the failing build check.

I signed-off my commits, but it looks like my email address was incorrect in my local git configt! I've since corrected it and signed-off the commits again, however DCO is still complaining about the previous/invalid email. I'll close this PR and raise another. Sorry for the hassle.

shaikhu commented 4 months ago

Thanks for the PR @shaikhu. Can you please sign-off your commits to make the DCO check happy? You can find instructions on how to do that by clicking on the Details link next to the failing build check.

I signed-off my commits, but it looks like my email address was incorrect! I've since corrected it and signed-off the commits, however DCO is complaining about the previous/invalid email. I'll close this and raise another PR. Sorry for the hassle.

New PR found here.