search

CycloneDX / cyclonedx-ruby-gem

Creates CycloneDX Software Bill of Materials (SBOM) from Ruby projects
https://cyclonedx.org/
Apache License 2.0
21 stars 20 forks source link

Add acceptance and unit testing #21

Closed mscottford closed 1 year ago

mscottford commented 1 year ago

I have some new features that I'd like to add, and I wanted to make sure I kept all existing behavior in the process, so I added test coverage as a first step. This pull request brings the line coverage to ~85% and the branch coverage to about ~70%. Coverage is measured via simplecov integration and can be cleanly generated by running bundle exec rake.

mscottford commented 1 year ago

In response to the DCO failure, I'll be signing all of my commits and doing a force push after that's done.

stevespringett commented 1 year ago

Big thanks for the PR. I had to update the GitHub actions that were used. The ones specified were deprecated and no longer supported. Could you sync your fork to master? I'd like to get a passing build before merge.

mscottford commented 1 year ago

Big thanks for the PR. I had to update the GitHub actions that were used. The ones specified were deprecated and no longer supported. Could you sync your fork to master? I'd like to get a passing build before merge.

Not a problem! I've rebased off of master and I've signed my commits.

mscottford commented 1 year ago

I see that CI is still failing. I'm going to work on getting that to pass. I'm going to add a matrix of ruby versions to test against.

mscottford commented 1 year ago

I see that CI is still failing. I'm going to work on getting that to pass. I'm going to add a matrix of ruby versions to test against.

CI appears to have been failing because activesupport version 7.x does not support Ruby versions older than 2.7, so I removed Ruby 2.6 from the support matrix. If Ruby 2.6 needs to be supported, then we'll need to depend on an older version of activesupport.

mscottford commented 1 year ago

Yay! That's a passing build, @stevespringett. Please let me know if you have any code review feedback.

stevespringett commented 1 year ago

Fantastic. Thanks so much for the PR.