Remove `--allow-dirty` option (v2) …

[Olf0]

… from cargo publish calls in the CI/CD workflows, because this option prevents creating a .cargo_vcs_info.json file. This should (really) close https://github.com/rust-lang/crates.io/issues/8551, see there for details. Now a cargo package with --allow-dirty executes all steps a cargo publish does except publishing, then the changes are committed back to the git repo and lastly cargo publish is run; for details see last paragraph of https://github.com/CycloneDX/cyclonedx-rust-cargo/pull/702#issuecomment-2130606809.

Supersedes PR #702

Signed-off-by: olf Olf0@users.noreply.github.com

[Shnatsel]

My comments from the previous iteration still apply: https://github.com/CycloneDX/cyclonedx-rust-cargo/pull/718#issuecomment-2130661391

[Olf0]

My comments from the previous iteration still apply: #718 (comment)

So do my checks & balances questions I compiled there meanwhile: https://github.com/CycloneDX/cyclonedx-rust-cargo/pull/718#issuecomment-2130672770

[Shnatsel]

The --allow-dirty flag was removed in #724, so I understand this is no longer necessary?

[Olf0]

The --allow-dirty flag was removed in #724, so I understand this is no longer necessary?

I assumed so, but when retesting the original issue it still does not work.

Please note that also a trivial, quick&dirty workaround exists, as denoted in https://github.com/CycloneDX/cyclonedx-rust-cargo/pull/702#issuecomment-2105309981.

[Shnatsel]

I've just published a new release without --allow-dirty and the "contributing" link on https://crates.io/crates/cargo-cyclonedx works for me now.

Is there some other link that's broken that I am missing?

[Olf0]

I've just published a new release without --allow-dirty and the "contributing" link on https://crates.io/crates/cargo-cyclonedx works for me now.

Retested: Ack

Is there some other link that's broken that I am missing?

Nope, I assume I tested it before you published the new release.