DRY up the file with reusable blocks.

CycloneDX / transparency-exchange-api

A standard API specification for exchanging supply chain artifacts and intelligence

https://tc54.org/

Apache License 2.0

59 stars 9 forks source link

DRY up the file with reusable blocks. #84

Open vpetersson opened 2 days ago

vpetersson commented 2 days ago

Refs #79.

madpah commented 2 days ago

Am reviewing @vpetersson - I note we have a root level security: block, but also security sections at operation level - I don't think both are required...

vpetersson commented 2 days ago

Thanks for catching! Yes, reckless refactoring from me. Thanks for finding that. Fixing.

madpah commented 2 days ago

@vpetersson Line 66 (PATCH /product/{tea_product_identifier} requestBody could use #/schemas/compoents/base_product_fields

Another: POST /product requestBody

madpah commented 2 days ago

An example of another area we can consider schema consolidation:

GET /product parameters could make use of allOf if we create a Schema Object with the Pagination Parameters - as these are re-used in a few places.

we already have #/components/schemas/type_pagination_detail...

Thoughts @vpetersson ?