chromium_code =1 warnings

[GoogleCodeExporter]

enable 'chromium_code' and resolve build issues

Original issue reported on code.google.com by fbarch...@google.com on 28 Apr 2015 at 6:19

[GoogleCodeExporter]

On windows there is one warning:

source\scale.cc(793) : warning C4189: 'max_y' : local variable is initialized 
but not referenced

Original comment by fbarch...@google.com on 28 Apr 2015 at 6:22

[GoogleCodeExporter]

ninja: Entering directory `/b/build/slave/linux_tsan2/build/src/out/Release'
[1/8] CXX obj/source/libyuv.scale.o
FAILED: /b/build/goma/gomacc 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF 
obj/source/libyuv.scale.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 
-DNO_TCMALLOC -DDISABLE_NACL -DCHROMIUM_BUILD -DCR_CLANG_REVISION=223108 
-DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 
-DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 
-DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN 
-DENABLE_PRE_SYNC_BACKUP -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 
-DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS 
-DUSE_UDEV -DDONT_EMBED_BUILD_METADATA -DDCHECK_ALWAYS_ON=1 
-DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 
-DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 
-DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_PRINTING=1 
-DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 
-DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 
-DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 
-DV8_USE_EXTERNAL_STARTUP_DATA -DHAVE_JPEG -DUSE_LIBPCI=1 -DUSE_GLIB=1 
-DUSE_NSS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS 
-DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE 
-DTHREAD_SANITIZER -DDYNAMIC_ANNOTATIONS_EXTERNAL_IMPL=1 
-DWTF_USE_DYNAMIC_ANNOTATIONS_NOIMPL=1 -DNDEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 
-DWTF_USE_DYNAMIC_ANNOTATIONS=1 -Igen -I../../include -I../.. 
-I../../chromium/src/third_party/libjpeg_turbo 
'-I../../chromium/src/buildtools/third_party/libc++/trunk/include' 
'-I../../chromium/src/buildtools/third_party/libc++abi/trunk/include' 
-fstack-protector --param=ssp-buffer-size=4 -Werror -pthread 
-fno-strict-aliasing -Wall -Wno-unused-parameter 
-Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC 
-Wno-reserved-user-defined-literal -Xclang -load -Xclang 
/b/build/slave/linux_tsan2/build/src/third_party/llvm-build/Release+Asserts/lib/
libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang 
-plugin-arg-find-bad-constructs -Xclang check-weak-ptr-factory-order -Xclang 
-plugin-arg-find-bad-constructs -Xclang strict-virtual-specifiers 
-fcolor-diagnostics 
-B/b/build/slave/linux_tsan2/build/src/third_party/binutils/Linux_x64/Release/bi
n -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration 
-Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing 
-Wno-deprecated-register -Wno-inconsistent-missing-override -m64 -march=x86-64 
-fno-omit-frame-pointer -gline-tables-only -fsanitize=thread 
-fsanitize-blacklist=../../tools/memory/tsan_v2/ignores.txt -O2 -fno-ident 
-fdata-sections -ffunction-sections -funwind-tables -fno-exceptions -fno-rtti 
-fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11 
-nostdinc++  -c ../../source/scale.cc -o obj/source/libyuv.scale.o
../../source/scale.cc:660:13: error: unused function 'ScalePlaneBoxRow_C' 
[-Werror,-Wunused-function]
static void ScalePlaneBoxRow_C(int dst_width, int boxheight,
            ^
../../source/scale.cc:674:13: error: unused function 'ScalePlaneBoxRow_16_C' 
[-Werror,-Wunused-function]
static void ScalePlaneBoxRow_16_C(int dst_width, int boxheight,
            ^
2 errors generated.
ninja: build stopped: subcommand failed.

Original comment by fbarch...@google.com on 28 Apr 2015 at 6:44

[GoogleCodeExporter]

c:\src\libyuv2\trunk>set GYP_DEFINES=target_arch=x64

c:\src\libyuv2\trunk>call python build\gyp_chromium -fninja -G 
msvs_version=2013 --depth=. libyuv_test.gyp
Updating projects from gyp files...

c:\src\libyuv2\trunk>ninja -C out\Debug_x64
ninja: Entering directory `out\Debug_x64'
[34/127] CXX obj\source\libyuv.mjpeg_decoder.obj
FAILED: ninja -t msvc -e environment.x64 -- 
"c:\bin\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo 
/showIncludes /FC @obj\source\libyuv.mjp
eg_decoder.obj.rsp /c ..\..\source\mjpeg_decoder.cc 
/Foobj\source\libyuv.mjpeg_decoder.obj /Fdobj\libyuv.cc.pdb
c:\src\libyuv2\trunk\source\mjpeg_decoder.cc(42) : error C2220: warning treated 
as error - no 'object' file generated
c:\src\libyuv2\trunk\source\mjpeg_decoder.cc(42) : warning C4324: 
'libyuv::SetJmpErrorMgr' : structure was padded due to __declspec(align())
[34/127] CXX obj\source\libyuv.convert_jpeg.obj
ninja: build stopped: subcommand failed.

Original comment by fbarch...@google.com on 28 Apr 2015 at 9:01

[GoogleCodeExporter]

Fixed in r1389
I thought I saw an arm build issue, but can't reproduce one at the moment.  Try 
bots look green.  Local ios 64 and 32 bit builds work.

Original comment by fbarch...@google.com on 29 Apr 2015 at 7:45

• Changed state: Fixed

[GoogleCodeExporter]

build bot android failure

ninja: Entering directory `/mnt/data/b/build/slave/android/build/src/out/Debug'
[1/11] CXX obj/source/libyuv_neon.scale_neon.o
[2/11] CXX obj/source/libyuv.mjpeg_decoder.o
[3/11] CXX obj/source/libyuv.scale.o
FAILED: /mnt/data/b/build/goma/gomacc 
/mnt/data/b/build/slave/android/build/src/third_party/android_tools/ndk//toolcha
ins/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g+
+ -MMD -MF obj/source/libyuv_neon.scale_neon.o.d -DV8_DEPRECATION_WARNINGS 
-D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DDISABLE_NACL -DCHROMIUM_BUILD 
-DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DUSE_PROPRIETARY_CODECS 
-DENABLE_BROWSER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS 
-DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY 
-DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DDONT_EMBED_BUILD_METADATA 
-DENABLE_AUTOFILL_DIALOG=1 -DCLD_VERSION=1 -DENABLE_PRINTING=1 
-DENABLE_BASIC_PRINTING=1 -DENABLE_SUPERVISED_USERS=1 -DVIDEO_HOLE=1 
-DV8_USE_EXTERNAL_STARTUP_DATA -DUSE_LIBPCI=1 -DUSE_OPENSSL=1 
-DUSE_OPENSSL_CERTS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DANDROID 
-D__GNU_SOURCE=1 -DUSE_STLPORT=1 -D_STLP_USE_PTR_SPECIALIZATIONS=1 
'-DCHROME_BUILD_ID=""' -DHAVE_SYS_UIO_H -DDYNAMIC_ANNOTATIONS_ENABLED=1 
-DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -Igen -I../../include -I../.. 
-fstack-protector --param=ssp-buffer-size=4 -Werror -fno-strict-aliasing -Wall 
-Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe 
-fPIC -Wno-unused-local-typedefs -mfpu=neon -march=armv7-a 
-mtune=generic-armv7-a -mfloat-abi=softfp -mthumb -fno-tree-sra 
-fno-caller-saves -Wno-psabi -mthumb-interwork -ffunction-sections 
-funwind-tables -g -fstack-protector -fno-short-enums -finline-limit=64 
-Wa,--noexecstack 
--sysroot=/mnt/data/b/build/slave/android/build/src/third_party/android_tools/nd
k//platforms/android-14/arch-arm 
-isystem/mnt/data/b/build/slave/android/build/src/third_party/android_tools/ndk/
/sources/cxx-stl/stlport/stlport -Os -g -gdwarf-4 -fdata-sections 
-ffunction-sections -fomit-frame-pointer -funwind-tables -g0 -fno-exceptions 
-fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare 
-Wno-abi -std=gnu++11 -Wno-narrowing -Wno-literal-suffix  -c 
../../source/scale_neon.cc -o obj/source/libyuv_neon.scale_neon.o
../../source/scale_neon.cc: In function 'void 
libyuv::ScaleARGBCols_NEON(uint8*, const uint8*, int, int, int)':
../../source/scale_neon.cc:957:4: error: 'tmp' is used uninitialized in this 
function [-Werror=uninitialized]
   );
    ^
cc1plus: all warnings being treated as errors
ninja: build stopped: subcommand failed.

Original comment by fbarch...@google.com on 29 Apr 2015 at 11:02

• Changed state: Started

[GoogleCodeExporter]

fixed in r1392

Original comment by fbarch...@google.com on 30 Apr 2015 at 6:40

• Changed state: Fixed