search

CyclopsMC / CapabilityProxy

Access block capabilities from multiple sides
MIT License
5 stars 5 forks source link

Move to a data generator. #20

Closed LexManos closed 4 years ago

LexManos commented 4 years ago

Add Loot tables for the proxy blocks, so you actually get them back when dropping. Add advancements for unlocking the recipes.

I wanted to use your mod, and found that the blocks don't drop anything when broken. So this fixes that.

As a side note, I would advise you move away from @OnlyIn in your code. As designed it is NEVER to be used by Modders unless absolutely necessary to prevent a crash. The ONLY time that happens is if you have a common class, and the method signature has a Client only class in it. AND that class gets reflected over. So it's a VERY rare case... So.. Stop using it, it's bad.

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

rubensworks commented 4 years ago

Ah, it looks like I forgot to test block drops. (this issue may exists in some of my other 1.14 mods as well, I'll have to check) Thanks a lot for this @LexManos!

As a side note, I would advise you move away from @onlyin in your code. As designed it is NEVER to be used by Modders unless absolutely necessary to prevent a crash.

Good to know, I may have indeed been (ab)using it a bit too much.

FYI, I'm won't be near my main machine for the next couple of weeks, so I won't be able to publish a new release with this functionality until then. Feel free to throw up a dev build of this mod to seafiles for FC :-)