search

CyclopsMC / ColossalChests

For when regular chests are too small.
MIT License
18 stars 14 forks source link

[1.12.2] Huge lag when opening chests and looking at the inventory #130

Closed fkrisi11 closed 4 years ago

fkrisi11 commented 4 years ago

Issue type:

Performance issue

Short description:

After right clicking a bigger chest (like 20x20x20), it takes a while to actually get the GUI. After you get the GUI, it's very laggy. (I have 1 fps in a 20x20x20 obsidian chest gui)

Steps to reproduce the problem:

  1. Build 20x20x20 size obsidian chest
  2. Open it to observe the 2 problems

Versions:

rubensworks commented 4 years ago

Could you share your profiling output as described here? https://github.com/CyclopsMC/CyclopsCore/blob/master-1.12/.github/CONTRIBUTING.md#performance-issues-snail

GitHub
CyclopsMC/CyclopsCore
Minecraft library mod for EvilCraft, Integrated Dynamics and others. - CyclopsMC/CyclopsCore
fkrisi11 commented 4 years ago

Where should I upload the files? GitHub says it doesn't like it

fkrisi11 commented 4 years ago

Also... I can only run it on the server it seems, so I did that I just need to know where to upload the file to

rubensworks commented 4 years ago

Zipping and uploading should work.

fkrisi11 commented 4 years ago

Ah nice. It works like this. I hope this will be helpful in finding a solution.

What program do you use to analyze these files by the way? Just out of curiosity. server_sample.zip

rubensworks commented 4 years ago

Thanks!

I use VisualVM to open nps files btw.

fkrisi11 commented 4 years ago

I see. Thanks for that. Just wanted some insight ^^

rubensworks commented 4 years ago

To be honest, I don't see anything abnormal in the profiling output.

Could you try without any other mods installed? Because another mod may be causing the problem.

fkrisi11 commented 4 years ago

The scrolling performance is still horrible with just worldedit, jei and colossalchests installed. But the inventory rendering itself is not as bad now with just these mods. So I'm really not sure what causes this.

rubensworks commented 4 years ago

Ok, then I'm closing this issue. Should you (or anyone else) be able to provide more information that would point out this mod as the cause of the performance issue, be sure to let me know here.