CyclopsMC / CyclopsCore

Minecraft library mod for EvilCraft, Integrated Dynamics and others.
http://cyclopsmc.github.io/CyclopsCore/
MIT License
20 stars 29 forks source link

`dumpregistries` subcommand is not guarded by a permission #180

Closed andriihorpenko closed 4 months ago

andriihorpenko commented 6 months ago

Issue type:


Short description:

The dumpregistries subcommand has no permission requirement set, giving anyone an ability to execute this command. Even though this is not a vulnerability, this may cause unnecessary load on a server when used dozens of times by bad actors.

Steps to reproduce the problem:

  1. Be a player with no advanced permissions granted
  2. Use /cyclopscore dumpregistries

Expected behaviour:

Guard a command with an OP check or permission level >= 2, like vanilla does in dozens of commands.


Versions:

Log file:

No log file required

rubensworks commented 6 months ago

Thanks for reporting!