search

CyclopsMC / IconExporter

Exports item and block icons to files
MIT License
20 stars 7 forks source link

Slightly different lighting used in 1.15 #10

Open IronPiston opened 4 years ago

IronPiston commented 4 years ago

Issue type:

Short description:

Incorrect lighting is used on the 1.15 version. The GUI lighting was changed from 1.14, but the exported icons don't reflect this

Steps to reproduce the problem:

  1. Use the 1.15 version
  2. Export any block

Expected behaviour:

The exported icon should have identical lighting to the in-game icons

Versions:

rubensworks commented 4 years ago

What icons are you having issues with? Because they all work fine on my end.

IronPiston commented 4 years ago

This is stone from IconExporter minecraft__stone

And this is a cropped screenshot of stone in the player inventory Sprite-0001

If I use a color tester on the right face, they don't seem to match.

rubensworks commented 4 years ago

There seems to be a slight difference indeed if you look closely. Not sure if a fix for this will be easy, since I basically had to rewrite the whole lighting system to account for scaling.

Putting this issue on a lower priority.

PRs on this are welcome.