search

CyclopsMC / IconExporter

Exports item and block icons to files
MIT License
19 stars 7 forks source link

Failure to export items with slashes in key #26

Closed iTrooz closed 5 months ago

iTrooz commented 6 months ago

Issue type:

Short description:

Items with slashes in their key don't export, such as spawn eggs in Occultism (ATM9 modpack)

Steps to reproduce the problem:

It should export the texture

Versions:

Log file:

Relevant error: https://pastebin.com/74r2kWt3

More info

I think the correct course of action would be to replace slashes by ___ (to avoid confusion with other separators) at https://github.com/CyclopsMC/IconExporter/blob/b95d3c91f2498309262a541948fbbecadc1df0a9/src/main/java/org/cyclops/iconexporter/client/gui/ScreenIconExporter.java#L112, or create the required directory automatically I'd be ready to submit a PR for this, let me know what you think

rubensworks commented 6 months ago

Thanks for reporting!

rubensworks commented 6 months ago

think the correct course of action would be to replace slashes by ___ (to avoid confusion with other separators)

Sounds like a good solution indeed!