search

CyclopsMC / IconExporter

Exports item and block icons to files
MIT License
20 stars 7 forks source link

Record NBT tags of items in text files instead of in file names #5

Closed TowardtheStars closed 4 years ago

TowardtheStars commented 5 years ago

Issue type:

Short description:

Would you please use text files to record NBT tags of items instead of printing them on file names?

Since some OS and FS put a limit on the length of file name, it seems not convenient to simply export long NBT tags in file names. So such a long file name may raise an IOException when writing files.

The situation described above is possible when the user is working with mods such as TinkersConstruct, whose items always contain long NBT tags. A NBT tag of a tool from TinkersConstruct can easily reach 300 or more ASCII characters, and it will always get involved in task list when the user tries to export. It would get worse if the user installed some addons for TinkersContruct such as TAIGA and plusTiC.

rubensworks commented 5 years ago

Note to self: apply a deterministic hash of the NBT tag to use in the file name, and store the full tag contents in a meta file.