CyclopsMC / IconExporter

Exports item and block icons to files
MIT License
20 stars 7 forks source link

[1.14] Rendered Images cut off #7

Closed IronPiston closed 3 years ago

IronPiston commented 4 years ago

Issue type:


Short description:

After trying to render, the resulting were only the top left. Screenshot from 2019-11-24 18-23-50

Steps to reproduce the problem:

Run /iconexporter export [any scale]

Expected behaviour:

The images should be the full sprite/model, not a portion.


Versions:

rubensworks commented 4 years ago

Weird, it works with any scale for me...

What scale did you use for the screenshot above?

What OS are you using?

IronPiston commented 4 years ago

Scale for that screenshot was 512, but 32 gave the same problem.

I'm using Fedora 30 I think, I haven't updated in a while.

Weirdly, the 1.12 version works fine on the same computer.

rubensworks commented 4 years ago

I can't reproduce this myself unfortunately (works fine on Mac). If someone running on Linux would be able to debug this, that'd be great.

IronPiston commented 4 years ago

So I just tried again, and the issue seems to be gone(I just reinstalled Fedora in the last few days). This seems to have been a problem on my end, since the mod hasn't updated since I posted this issue.

rubensworks commented 4 years ago

That's good to hear, closing this then. Should anyone else experience this problem in the future, feel free to comment here.

Krutoy242 commented 4 years ago

1.12.2 First run of export command gave right result. But than i tried to enable general.fileNameHashTag=true. Now no matter of size i set - everything exported in half. I already tried to return options to original or reload minecraft - problem still here.

After some investigation, i found that it somehow connected with MC window size - when i resized window to maximum - problem disapear.

rubensworks commented 4 years ago

@Krutoy242 What OS are you using?

Krutoy242 commented 4 years ago

@Krutoy242 What OS are you using?

Windows 10

rubensworks commented 4 years ago

I'll look into it again in any case, but I'm using Mac, so I'm not able to do any debugging on Windows unfortunately.

rubensworks commented 4 years ago

I'm unable to reproduce this myself (on Mac) with different resolutions.

I highly suspect this is an OS-specific issue. Since I'm not able to debug this myself, I hope someone else is able to find the problem and suggest a PR.

MindGames18 commented 4 years ago

Hello there @rubensworks . I had the same issue in my windows 10. the exported icons were cut off partially. and after some time investigating it myself, I ended up finding out that turning the gameto full screen (F11 default for windows) before exporting fixes this issue.

Maybe you'll be able to reproduce this in mac if you try exporting from windowed mode (speculating) thanks! hope this info helps you and others who may stumble here

rubensworks commented 4 years ago

Note to self: auto-toggle full-screen mode when exporting.

Hekera commented 3 years ago

I think I've found the source of the issue, at least on Windows. It has to do with the GUI scale option in Minecraft video settings, which I've had on Auto. Changing resolutions/system scale/fullscreen around produces different results because it changes the GUI scale that Minecraft automatically determines. Once I set the GUI scale to a specific number, the results of the icon export remained consistent between resolutions/etc. GUI scale 2 seems to export icons that are the actual scale specified in the command, and that are not cut off.

DarkAngel22579 commented 3 years ago

Chiming in with a 1080p monitor (since Hek's is 1440p). Setting the GUI scale to 2 makes it export at the right scale, regardless of fullscreen/windowed. I normally have GUI set to 3, which caused a 50% increase in the size of the icons. I'd assume GUI scale 1 would cause a 50% decrease, but I haven't tested that.

rubensworks commented 3 years ago

Thanks for all the input. I've managed to reproduce the problem with different GUI scales. Fix incoming...