CyclopsMC / IntegratedCrafting

Craft stuff in Integrated Dynamics networks
MIT License
7 stars 6 forks source link

Invalid Chars in Tag Within Recipe Can Be Saved To Variable #103

Closed EddwardR closed 3 months ago

EddwardR commented 4 months ago

Issue type:


Short description:

When inputting a recipe in Programmer, using the format of #namespace:item instead of namespace:item within "Item tag variants" option can still be written to variable card if one is placed in output slot.

Steps to reproduce the problem:

  1. New Recipe in Logic Programmer
  2. Input a valid recipe that uses tags (sticks recipe is a good candidate) via JEI, REI or EMI
  3. Modify input tag on one of planks to contain an illegal character, like #
  4. Click variable card into output slot. This should result in a crash

Expected behaviour:

Blocking or otherwise disallowing a variable card to be written at all. An option would be blocking the output slot with the advanced config UI.


Versions:

Log file:

https://mclo.gs/HsROiiC

rubensworks commented 4 months ago

Thanks for reporting!