search

CyclopsMC / IntegratedCrafting

Craft stuff in Integrated Dynamics networks
MIT License
7 stars 6 forks source link

Recipes with "too many" ingredients fail to be crafted via terminal #110

Closed MrDj200 closed 3 weeks ago

MrDj200 commented 3 weeks ago

Issue type:

Short description:

When you make a Recipe that has more ingredients than the Logic Programmer has slots, you can't request the recipe via terminal, but it is possible via Crafting Writer.

Steps to reproduce the problem:

  1. Make a recipe with 10 misc. items (doesn't have to be an existing recipe)
  2. Put a crafting interface on a chest/barrel and insert recipe
  3. Make sure the items are available in the network
  4. Try to order through a Storage Terminal
  5. Restart game
  6. Try ordering again

(Alternatively, I've attached the modpack including the world I've used for testing. The pack has been exported as a CurseForge pack, so it should be compatible with most launchers) Integrated Dynamic Testing.zip

Expected behaviour:

I'd expect to be able to order my programmed recipe through the terminal

Versions:

Log file:

N/A

Additional Info:

This issue has a discord conversation preceding it: Messages on the CyclopsMC Discord

When I initially made the test setup, it worked, however after a world reload the issue started happening. That's why I've added step 5 for the reproduction.

rubensworks commented 3 weeks ago

Thanks for reporting!

battle00333 commented 3 weeks ago

Should mention that this is occuring with the "Recipe.with_io" operator. Ingredients -> Ingredients -> Recipe

I can confirm that I am also running into this issue when having an ingredient as input with more than 10 unique items.

Incidentally if you make a new card of the same signature and place it in a crafting terminal, it will flash an X for a brief moment before being recognized as valid. removing/adding a component also appears to trigger the card to be recognized as valid. I'll also mention that there was an "Unknown Error" that preceded this a couple days ago but so far it cannot be reproduced.

rubensworks commented 3 weeks ago

The fact that it works with the Crafting Writer but not the Terminal is strange. But it also makes me suspect that this one shouldn't be too difficult to fix, since we have one functional code path.

MrDj200 commented 3 weeks ago

The crafting writer also seems to have an issue with these kinds of recipes. The Ignore storage contents setting seems to be non functional for this. It works fine on "normal" recipes