Recipes with output items that can have charge are 'invalid' in the crafting interface

[tinyrobot]

Issue type:

• :bug: Bug

---

Short description:

Crafting recipes with outputs that can have variable charge (eg. integrated dynamics battery) are marked as 'invalid' when placed in a crafting interface.

Steps to reproduce the problem:

1. Create a recipe for the integrated dynamics battery:

2. Place the recipe in a crafting interface attached to a crafting table:

Expected behaviour:

The recipe should be valid

---

Versions:

• This mod: 1.0.2
• Minecraft: 1.12.2
• Forge: 14.23.5.2772

[rubensworks]

Probably because NBT checking is too strict here...

[rubensworks]

Will be fixed in the next ID updated. You will have to re-obtain the battery item and re-create the recipe though.

[tinyrobot]

@rubensworks - sorry to comment on a closed issue; yesterday I tried this again with: IntegratedDynamics-1.12.2-1.0.8 IntegratedCrafting-1.12.2-1.0.5

And it still seems to be occurring - I created a new recipe, shift clicked the Integrated Dynamics Battery in from JEI, and when attempting to add to a Crafting Interface I still get the red X with the 'recipe is invalid for this...' message. Have I missed updating something?

[rubensworks]

shift clicked the Integrated Dynamics Battery in from JEI

I never tried that to be honest. Does it work if you just craft the battery and create the recipe from that?

[tinyrobot]

Unfortunately not, I just tried that - manually crafted the battery, manually inserted the ingredients in the 'recipe' grid and manually placed the crafted battery into the output slot. When the recipe is placed in the crafting interface, the message is 'Recipe is not acceptable by the target'.

[rubensworks]

So, I just tried this myself again, and everything works as intended.

I tried the following things:

• Clicking the energy battery recipe (from OP) from JEI into the LP, and inserting into crafting interface.
• Manually creating the energy battery recipe in the LP, and inserting into crafting interface.

Have you tried updating CyclopsCore and CommonCapabilities as well?

Things were changed in the NBT storage of the energy battery, so perhaps your world (or a mod) is caching some things. Have you tried with a clean world already?

[tinyrobot]

Apologies @rubensworks, have been on holiday. Will try this with a clean world and get back to you!

[tinyrobot]

I tried again, created a new creative world with these versions of everything:

CommonCapabilities-1.12.2-2.1.0 CyclopsCore-1.12.2-1.0.6 IntegratedCrafting-1.12.2-1.0.5 IntegratedDynamics-1.12.2-1.0.8 IntegratedTerminals-1.12.2-1.0.5 IntegratedTunnels-1.12.2-1.6.7

Forge: 14.23.5.2815

Recreated the recipe in the new world, and I get the same 'Recipe is not acceptable by the target' message in the crafting interface.

Should I be using dev builds for any of the above do you think?

[rubensworks]

@tinyrobot Could you share a video of what you are doing exactly? I assume we may be doing different things.

[tinyrobot]

Sure, here you go - sorry for the quality / length!

[tinyrobot]

@rubensworks - I just created a new minecraft instance using multimc with only the mods listed above, and JEI, and it works as expected. So it must be something to do with the modpack I was previously using.

Happy for this to be closed, but would you have any idea/advice on what might be causing the issue in a modpack?

[rubensworks]

would you have any idea/advice on what might be causing the issue in a modpack?

Hmm, interesting. Perhaps you have a mod that is either changing recipes or a mod that is adding NBT tags to items?

[tinyrobot]

I'm not sure to be honest, it's an FTB modpack (dw20). I'll have a Google and see if I can find out, but it's obviously not an issue with IC - apologies for reopening!

[rubensworks]

Oh, no problem at all. Should you (or anyone else) gain any new information on this, be sure to comment here! :-)

[tinyrobot]

Sorry to again comment on a closed issue @rubensworks - I made my own modpack using multimc and enabled the mods one by one. The issue is caused by Astral Sorcery (and only Astral Sorcery - I tested its dependency on 'Baubles' which is also required by Botania and the recipe card is fine. If you enable all other mods and only disable Astral Sorcery itself, the recipe card for this works.)

Now, regarding further debugging I'm at a bit of a loss - do you have any tips for how I might find out what exactly Astral Sorcery might be doing that specifically affects the validity of this recipe card?

[rubensworks]

@tinyrobot That is interesting...

It's possible that AS is adding NBT or capabilities to all items. You may be able to see this by looking at the NBT tags of a random item (like ID's Energy Battery), and comparing when AS is installed or not.

Pinging @HellFirePvP to see if he knows what may be going on.

[tinyrobot]

Sorry was going to check yesterday - have just taken screenshots of the nbt of the energy battery without and with Astral Sorcery enabled:

Without Astral Sorcery:

With Astral Sorcery:

So it looks like when Astral Sorcery is enabled the Energy Battery has ForgeCaps: astralsorcery:cap_item_amulet_holder in its NBT (if I'm looking in the right place?)

I'm not sure what ForgeCaps is, but I hope this is a bit helpful?

[rubensworks]

Good catch, that would indeed explain the problems we are having here!

I'll see what can be done about that. I think I may have to make NBT comparisons a bit less strict.

[HellFirePvP]

may have to make NBT comparisons a bit less strict.

Which would be my first suggested approach. Unfortunately, i can't make the forge capabilities return "please save nothing at all", so it'll always save an empty tag, commonly messing up other mods' strict NBT checks when it comes to items.

[rubensworks]

Ok, I went all the way with this fix 😄 (part of this fix will be reusable for https://github.com/CyclopsMC/IntegratedDynamics/issues/596) I'll release a new CommonCaps version containing this fix soon.

[TomyLobo]

I have this problem with our own modpack. Not sure which mod causes this, though, but if i create a new modpack with just integrated dynamics/terminals/crafting/tunnels and JEI, it works. Here's our mod list:

mod	version
ActuallyAdditions	1.12.2-r150
AutoRegLib	1.3-32
BarrelsDrumsStorageAndMore	0.0.24
BetterFps	1.4.8
biggerpacketsplz-since1.8	1.2
BiomesOPlenty	1.12.2-7.0.1.2443
CodeChickenLib	1.12.2-3.2.3.358
CoFHCore	1.12.2-4.6.3.27
CoFHWorld	1.12.2-1.3.1.7
CommonCapabilities	1.12.2-2.4.4
Controlling	3.0.7
CraftTweaker2	1.12-4.1.19
CreativeCore	v1.9.70_mc1.12.2
CTM-MC1.12.2	1.0.0.29
CyclopsCore	1.12.2-1.5.1
DynamicLights	1.12.2
DynamicTrees	1.12.2-0.9.5
DynamicTreesBOP	1.12.2-1.4.1e
EnderStorage	1.12.2-2.4.6.137
FastFurnace	1.12.2-1.3.1
FastWorkbench	1.12.2-1.7.2
forestry_1.12.2	5.8.2.408
FTBLib	5.4.3.145
FTBUtilities	5.4.0.110
FTBUtilitiesBackups	1.0.0.12
funky-locomotion	1.12.2-1.1.2
IntegratedCrafting	1.12.2-1.0.8
IntegratedDynamics	1.12.2-1.1.0
IntegratedTerminals	1.12.2-1.0.12
IntegratedTunnels	1.12.2-1.6.10
InventoryTweaks	1.63
jei_1.12.2	4.15.0.291
jeiintegration_1.12.2	1.5.1.36
journeymap	1.12.2-5.5.5
JustEnoughResources	1.12.2-0.9.2.60
LittleTiles	v1.5.0-pre170_mc1.12.2
LLOverlayReloaded	1.1.6-mc1.12.2
Mantle	1.12-1.3.3.55
modtweaker	4.0.17
MTLib	3.0.6
OptiFine	1.12.2_HD_U_E3
Patchouli	1.0-20
Quark-r1.6	177
railcraft	12.0.0
reauth	3.6.0
RedstoneFlux	1.12-2.1.0.6
TConstruct	1.12.2-2.13.0.171
theoneprobe	1.12-1.4.28
ThermalDynamics	1.12.2-2.5.5.21
ThermalFoundation	1.12.2-2.6.3.27
TombManyGraves	1.12-4.2.0
twilightforest	1.12.2-3.9.984
UniDict	1.12.2-2.9.3
WanionLib	1.12.2-2.4
WorldEdit CUI Forge Edition 2	2.2.0-mf-1.12.2-14.23.5.2768

All of them updated to latest betas today

[TomyLobo]

If you want me to test out various combinations of those mods, I'll gladly do so, but i have no idea where to start. You probably have more insight into this :)

[rubensworks]

Perhaps some mod in your pack is adding some additional NBT/capabilities to items. Could you have a look at the NBT tags of your items to see if anything special is going on?

[TomyLobo]

okay I have officially no idea what's going on. The issue is 100% reproducible on my Nitrado-hosted server, but if I use the same config and mods directories on a client, and download the world and open it on Windows, I can no longer reproduce the problem. I can send you my map if you want to try it out.

[rubensworks]

Perhaps it only happens in SMP?