search

CyclopsMC / IntegratedCrafting

Craft stuff in Integrated Dynamics networks
MIT License
7 stars 6 forks source link

Removing a duplicate recipe hides it from the terminal #38

Closed TomyLobo closed 4 years ago

TomyLobo commented 4 years ago

Issue type:

Short description:

If you have one recipe in multiple crafting interfaces, then remove one of them, the recipe is no longer craftable through the terminal.

These two spots in CraftingNetwork.java seem to be responsible for this: https://github.com/CyclopsMC/IntegratedCrafting/blob/master-1.12/src/main/java/org/cyclops/integratedcrafting/core/network/CraftingNetwork.java#L149-L150 https://github.com/CyclopsMC/IntegratedCrafting/blob/master-1.12/src/main/java/org/cyclops/integratedcrafting/core/network/CraftingNetwork.java#L197-L198

I think scanning the remaining interfaces for the recipes and then not removing it would be the most efficient solution that doesn't require more state.

Steps to reproduce the problem:

  1. Place Logic Cable
  2. Place Storage Terminal on Logic Cable
  3. Place 2 Crafting Interfaces on Logic Cable
  4. Create 2 identical recipes
  5. Place one of the recipes in each of the Crafting Interfaces
  6. Remove the recipe from one of the Crafting Interfaces
  7. Open the Storage Terminal
    • Expected: Recipe visible
    • Actual: Recipe not visible

Versions:

Integrated Dynamics: 1.1.1 Integrated Terminals: 1.0.13 Integrated Tunnels: 1.6.10 Cyclops Core: 1.6.0 CommonCapabilities: 2.4.5

Log file: