search

CyclopsMC / IntegratedCrafting

Craft stuff in Integrated Dynamics networks
MIT License
7 stars 6 forks source link

Integrated Dynamics' Energy Battery recipe invalid in crafting interface on world restart #68

Closed NielsPilgaard closed 2 years ago

NielsPilgaard commented 2 years ago

Relayed from: https://github.com/NillerMedDild/Enigmatica6/issues/3207

Issue type:

Short description:

When setting up a crafting interface to allow autocrafting of Integrated Dynamics energy batteries, the recipe card is initially accepted and works as intended. However, when the world is quit and reloaded, the recipe is marked as invalid and has to be cleared and replaced with a new, otherwise identical recipe card. As far as I can tell, nothing short of making a new one will actually fix the issue.

Expected behaviour:

For the recipe to work after restarting

Versions:

Log file:

latest.log

rubensworks commented 2 years ago

Thanks for reporting!

rubensworks commented 2 years ago

I suspect there's another mod in the pack that injects (pseudo-random?) tags onto FE-holding items, which vary upon world reloads, because I can't reproduce this with just ID mods installed.

@NillerMedDild Do you have an easy way to check the NBT tags of a battery item? If so, could you share its contents with me?

If we find a varying tag, it should be possible to add it to the ignoreNbtPathsForEqualityFilters list in the Common Capabilities config, which should fix the problem. Happy to add it to the default list once such a tag has been identified.

NielsPilgaard commented 2 years ago

I'm afraid the NBT tag only has energy in it:

Item.of('integrateddynamics:energy_battery', '{energy:1000000}')

It does not get modified on restarts either.

rubensworks commented 2 years ago

Thanks for checking. Then the problem must lie elsewhere, not sure where yet though...

rubensworks commented 2 years ago

@NillerMedDild Just out of curiosity, does adding "$.energy" to the ignoreNbtPathsForEqualityFilters list in CommonCaps influence the issue in any way?

NielsPilgaard commented 2 years ago

I've asked the original reporter to try it out, as I don't have the setup handy :)

NielsPilgaard commented 2 years ago

It didn't work I'm afraid.

rubensworks commented 2 years ago

Note to self: before closing this issue, make logRecipeValidationFailures config option false by default.

rubensworks commented 2 years ago

Fixed confirmed in https://github.com/NillerMedDild/Enigmatica6/issues/3207