The crafting writers "ignore storage contents" property seems to override "ignore crafting jobs"

[elias098]

Issue type:

• :bug: Bug

---

Short description:

If you enable the "ignore storage contents" it seems to act as if "ignore crafting jobs" is also enabled.

Steps to reproduce the problem:

i have to admit that i have not tested the following ingame due to having lost my account, but i have heard others say this and the code supports it

1. place a crafting writer on a network with recipes
2. set the writer to start one of the existing recipes
3. enable "ignore storage contents"
4. watch the crafting job list fill up

Expected behaviour:

I would expect the 2 properties to work independently of each other

the code for this interaction seems to be

ignoreStorage
||
(
  !CraftingHelpers.hasStorageInstance(...)
  && 
  (
    ignoreCrafting || !CraftingHelpers.isCrafting(...)
  )
)

while i would expect it to be

(
  ignoreStorage || !CraftingHelpers.hasStorageInstance(...)
)
&&
(
  ignoreCrafting || !CraftingHelpers.isCrafting(...)
)

---

Versions:

i know it says to not use just "latest" but looking at the code for this it affects all versions

Log file:

[rubensworks]

Thanks for reporting!