CyclopsMC / IntegratedCrafting

Craft stuff in Integrated Dynamics networks
MIT License
7 stars 6 forks source link

Autocrafting gets stuck if the crafted item is moved. #98

Closed derram closed 10 months ago

derram commented 10 months ago

Issue type:


Short description:

Tested here with a barebones setup of Integrated Dynamics/Crafting/Terminals/Tunnels, Common Capabilities, and Cyclops Core.

Autocrafting continues if output remains in a storage container, thinks the output is missing if the item is moved.

Steps to reproduce the problem:

A setup for crafting granite, no hopper under output (interface on right has highest priority): 2023-09-01_03 51 51

Crafting proceeds as expected. 2023-09-01_03 51 41

Add hopper below output chest.

2023-09-01_03 52 08

Crafting grinds to a halt.

2023-09-01_03 52 02

This also happened to me in a modpack when I used a filtered interface to put the output directly into a machine. In that case it was a Create Millstone.

Expected behaviour:

Autocrafting should be able to tell when it's put the crafted item away.


Versions:

2023-09-01_04-06

2023-09-01_04-07

rubensworks commented 10 months ago

Thanks for reporting!

rubensworks commented 10 months ago

Note to self: similar to an issue with crafting item exporter. There, we added a forced index reload once the crafting job is done. We need something like that here as well, to make sure we add the crafted item to the index so it's marked as "completed" before the hopper pulls it out again.

derram commented 10 months ago

Note the bit I said about the filtered interface.

I was hoping to skirt around the problem by having ID handle the entire process, all on the same network, and it still lost track of the output.

derram commented 10 months ago

Did a bit more testing, and yeah using a filtered interface on the hopper causes the same problem.

2023-09-01_04 30 41

2023-09-01_04 30 44

rubensworks commented 10 months ago

A temporary workaround would be to replace the hopper with an ID exporter that is attached to the main network.

derram commented 10 months ago

Went back to the pack to implement the change, and I can't tell if I'm hitting the same bug while using the exporter or a similar but different bug.

In the pack I am crafting cobble + quartz to diorite and then diorite and quartz to granite. I think it might be getting stuck on the diorite side of things which doesn't send anything out of the network.

That's just a crafting interface and interfaces on the storage containers, and then the crafting interface for granite pulls from the output from the diorite crafter.

derram commented 10 months ago

Yeah, did some more testing in the barebones install, and the crafting chugs along fine for a bit, but then gets stuck more than likely because of the diorite crafting. There's an exporter attached to the back side of that barrel on the bottom right.

2023-09-01_05 58 53