CyclopsMC / IntegratedDynamics

A Minecraft mod to take full and automated control of your appliances.
http://cyclopsmc.github.io/IntegratedDynamics/
MIT License
126 stars 59 forks source link

Inconsistent behavior of Labeller for non-variable items. #1353

Closed markuskoeppen closed 1 week ago

markuskoeppen commented 1 week ago

Issue type:


Short description:

When using the Labeller to rename initialized variables, the name field is updated to the current name of the variable upon adding it. However, this isn't the case for non-variable items, which can also be renamed using the Labeller.

Steps to reproduce the problem:

  1. Get a programmer and a labeler.

  2. Create a Boolean false variable and name it "Named" in the programmer.

  3. Get a stone sword. Rename it "Also named" in an anvil or a Labeller.

  4. Open a Labeller and add the variable card. The name field will now read "Named".

  5. Remove the variable card.

  6. Add the stone sword. The name field will still be empty.

Expected behaviour:

The name field contains the string "Also named" in step 6.


Versions:

First found in ATM9 NF, then reproduced in raw forge install.

Log file:

rubensworks commented 1 week ago

Thanks for reporting!

markuskoeppen commented 1 week ago

Correction: Only happens in connection with #1352.