search

CyclopsMC / IntegratedDynamics

A Minecraft mod to take full and automated control of your appliances.
http://cyclopsmc.github.io/IntegratedDynamics/
MIT License
135 stars 62 forks source link

Combine cable voxel shape components in getShape rather than getCollisionShape #1389

Closed embeddedt closed 2 months ago

embeddedt commented 2 months ago

This PR moves BlockCable's conversion from VoxelShapeComponents to a vanilla VoxelShape into the more generic getShape function, rather than getCollisionShape. This makes the conversion apply to the block's occlusion shape as well and not just the collision shape.

This is needed to fix a compatibility issue with Moonrise which cannot handle the custom VoxelShapeComponents implementation. I suspect it might also fix some as-of-yet-unknown issue with cable occlusion, as the occlusion logic uses VoxelShape operations just like entity collisions.

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

rubensworks commented 2 months ago

Thanks @embeddedt! I will release this soon.