Server Hanging when a certain player logs off

CyclopsMC / IntegratedDynamics

A Minecraft mod to take full and automated control of your appliances.

http://cyclopsmc.github.io/IntegratedDynamics/

MIT License

130 stars 62 forks source link

Server Hanging when a certain player logs off #1411

Open jinkhya opened 1 day ago

jinkhya commented 1 day ago

Issue type:

:bug: Bug

Short description:

Hello ! So this is kinda a weird one... We've had a problem with server hanging when a specific player disconnects from the server and we're trying to narrow it down. Today it generated a crash-log : https://gist.github.com/jinkhya/9ba485a2dc430983d1943fc6ad06b3be Hopefully you can decipher what caused the crash :sweat_smile:

Steps to reproduce the problem:

Well... I can't tell you how to reproduce it, it only happens with one of our players :( If you have an idea on what is causing it I can test things out though !

Expected behaviour:

To not make the server hang I suppose :)

Versions:

This mod: 1.23.9
Minecraft: 1.21.1
Mod loader version: Neoforge 21.1.72

Log file:

https://gist.github.com/jinkhya/351a1e357ccdff8cc11858de6c39a559

rubensworks commented 1 day ago

Thanks for reporting!

rubensworks commented 22 hours ago

I've had a look at this, and it looks like there is probably some race condition during chunk loading/unloading.

I'm not sure at the moment that ID is the cause of the problem. It could very well be that there is some underlying problem (possibly through some other mod) that is causing this, and by chance ID could also be running into trouble because of this underlying problem every now and then. This could explain this crashlog only happening sometimes, while the server simply keeps on hanging all of the other times.

I'll place this issue on-hold for now. Should you learn about any additional information that could be relevant, please let me know.

jinkhya commented 3 hours ago

Hello,

The issue happened again today and I did a good bit of testing. I narrowed down the issue to be between ID and AE2. I copied the region file at fault into a world within an instance with those 2 mods (and their libraries) I'll give you the zip of the world if you want to have a look. It's definitely a weird issue : If I break everything from AE2 it fixes it, if I break everything from ID, it also fixes it. And those 2 mods aren't connected in any way so I don't understand lol. They are in the same chunk though.

To reproduce :

Make a 1.21.1 instance with AE2 + ID + dependencies
Load the world I'm giving you and go to 4979 58 3317 coordinates
Save and exit. The world is stuck at saving
if you load it again and break AE2 or ID setup, you'll see that when you save and exit the world, it takes half a second and is fine.

world.zip

If you need anything else lemme know !

rubensworks commented 1 hour ago

I see, that's interesting.