search

CyclopsMC / IntegratedDynamics

A Minecraft mod to take full and automated control of your appliances.
http://cyclopsmc.github.io/IntegratedDynamics/
MIT License
126 stars 61 forks source link

Support network movement with frames #443

Open FallenRecruit opened 6 years ago

FallenRecruit commented 6 years ago

Issue type: Bug

Expected behaviour: Game should function as normal

Actual behaviour: Crashes with error log

crash-2017-12-08_18.55.49-server.txt

Steps to reproduce the problem:

2017-12-08_19 49 31

  1. Make funky locomotion frame contraption that pushes Energy exporter that is on a cable
  2. Push frame

Versions:

Log file:

https://pastebin.com/5wzgu52Q

rubensworks commented 6 years ago

Yeah, this was to be expected, don't move ID networks with frames (for now). Most likely we'll have to add custom support for FL.

josephcsible commented 6 years ago

If you want to support this now, should we also reopen #309?

rubensworks commented 6 years ago

Quark doesn't provide an API for this AFAIK. So we'll have to wait and see if this can be solved without using the FL API, if so, this should automatically work with Quark as well.

octylFractal commented 2 years ago

I would appreciate if before if the network even worked while on a "frame mod", that it did not crash at all. It is sometimes hard to predict when certain blocks are going to be moved, and with the new "full block" status of cables, it's extremely easy to move cables by accident. Having this crash a server is confusing, and could be easily (I think) avoided by correctly removing parts from the network when the block entity is removed.

rubensworks commented 2 years ago

Having this crash a server is confusing, and could be easily (I think) avoided by correctly removing parts from the network when the block entity is removed.

@octylFractal ID should already be cleaning up things correctly when blocks are removed. But you're welcome to submit a PR if you think anything needs to be changed 🙂

octylFractal commented 2 years ago

I would submit a PR, but the build seems to require me to have a username and password for a Maven repository (or maybe for me to install everything CyclopsMC from scratch), and your CLA requires write access to my gists. This is a non-starter for me, so I am unable to make a PR.