search

CyclopsMC / IntegratedDynamics

A Minecraft mod to take full and automated control of your appliances.
http://cyclopsmc.github.io/IntegratedDynamics/
MIT License
133 stars 62 forks source link

Drying basin disappearing when filled with lava #543

Open wizard1399 opened 6 years ago

wizard1399 commented 6 years ago

Issue type:

Only keep the issue types that are applicable.

Short description:

Drying basin disappears when filled with lava. I was in creative mode and placed a bucket of lava into the drying basin. Shortly after the basin disappears from the world.

Expected behaviour:

Drying basin to stay in world with lava in it. I have a craft tweaker script that relies on using lava with the drying bin.

Actual behaviour:

"Poof" the bin is gone.

Steps to reproduce the problem:

  1. Creative mode
  2. Place down drying basin
  3. Place a bucket of lava into basin
  4. After a second or two it should vanish.

Versions:

_

Log file:

Null

rubensworks commented 6 years ago

That's not a bug, it's a feature!

Regular drying basins will burn down if they contain hot fluids, such as lava.

I could add a config option to disable this behaviour though...

wizard1399 commented 6 years ago

Could you add the config to the 1.10.2 version? The minetweaker script that lead to this discovery has to do with thaumcraft and getting aspect crystals in a void world. Azanor has said that TC will be dev'ed in 1.10.2 to work most of the bugs out before moving on to 1.12.

TLDR: adding the config to 1.12 will not solve the problem for me or the magic based skyblock pack I am developing. I know this would be back tracking for you, so I would like to thank you profusely in advance.

rubensworks commented 6 years ago

Sorry, 1.10.2 is not maintained anymore unfortunately, I simply do not have the time for it.

rubensworks commented 6 years ago

@wizard1399 You're welcome to fork the 1.10.2 version and build a custom version by changing the following field yourself though: https://github.com/CyclopsMC/IntegratedDynamics/blob/master-1.12/src/main/java/org/cyclops/integrateddynamics/tileentity/TileDryingBasin.java#L33

GitHub
CyclopsMC/IntegratedDynamics
IntegratedDynamics - A Minecraft mod to take full and automated control of your appliances.
wizard1399 commented 6 years ago

Not asking to maintain, just a quick fix. Possible comment out a few lines of code responsible for the burning down feature, slap a hotfix label on it and release it.

ouroborus commented 6 years ago

Maybe a fire animation if they're going to burn down? Seems like currently there's no clue as to what happened so you can't tell if this was intended or not.

rubensworks commented 6 years ago

It spawns a fire block after burning down.

7eggert commented 3 years ago

It should spawn a lava block?