search

CyclopsMC / IntegratedDynamics

A Minecraft mod to take full and automated control of your appliances.
http://cyclopsmc.github.io/IntegratedDynamics/
MIT License
128 stars 61 forks source link

Snow settles on cables #634

Closed DaedalusGame closed 5 years ago

DaedalusGame commented 5 years ago

Issue type:

Short description:

grafik Cables don't appear to implement Block::getBlockFaceShape. This means that they default to all sides being solid, causing numerous funky artifacts like torches, levers and snow being placeable on them, with a massive airgap, naturally.

Steps to reproduce the problem:

1a. Place cables in a snowy biome in a snowstorm 1b. Place cables 2b. Place torch on cables

Expected behaviour:

Snow to not settle on cables in a particularly ugly fashion

Versions:

Log file:

N/A

rubensworks commented 5 years ago

Oh, is getBlockFaceShape a new thing? Never heard of it before.

rubensworks commented 5 years ago

Actually, I remember there being another method for that. Because I'm pretty sure you could not place levers on cables before, unless that cable had a part on that side.

DaedalusGame commented 5 years ago

getBlockFaceShape was added either in 1.11 or 1.12, and yeah a lot of mods seem to have missed it. Before levers and such looked for isSideSolid. FaceShape actually handles even more than just what you can place on a block, it's also for connecting fences, walls and panes together.