CyclopsMC / IntegratedTerminals

Terminals for managing and overviewing Integrated Dynamics networks
MIT License
5 stars 6 forks source link

unable to auto complete certain recipes from jei even though the items are in the system #31

Closed Fedwick closed 5 years ago

Fedwick commented 5 years ago

Issue type:

auto complete certain recipes from jei

Short description:

unable to pull certain recipes from jei even though the items are in the system

Steps to reproduce the problem:

i will give 1 item as an example, the world block exporter

  1. get a container with an item interface and a storage terminal
  2. place an item exporter, a logic director and a diamond pick in your system
  3. open your storage terminal and click the world block exporter from jei and then click the +sign to pull the recipe in your monitors crafting grid (it does not recognize the pick)

Expected behaviour:

it should auto complete the recipe because you have a diamond pick in your system

Versions:

rubensworks commented 5 years ago

Does the pick have damage on it? Does this happen for all recipes, or only recipes with damageable items?

Fedwick commented 5 years ago

i will try to give you a few items, this is my test pack most of the recipes work ok ! there are a few items that don't work, maybe it has something to do with NBT or damage ? my programming experience in MC is almost 0 though so i don't know.

this is a basic storage system 2019-04-26_12 18 49

all the indigence for world block exporter are inside and the pick is fresh 2019-04-26_12 19 07

i am unable to autocomplete 2019-04-26_12 19 25

now i will try a recipe from blood magic, all the items are in the system but i am unable to autocomplete the blood orb is in the system though ! 2019-04-26_12 24 46

ok now i switch to enigmatica 2 expert pack ( the pack only had tunnels and dynamics so i manually add integrated terminals )

i wanna craft energy interfaces all the items are in my system 2019-04-26_12 55 57

but i am unable to auto complete

2019-04-26_12 56 10

here i try to craft the automatic squeezer and it recognizes the batteries and the squeezers, but it does not recognize a squeezer that was placed and later picked up ! maybe something changed in the items NBT ? this recipe is changed by enigmatica but i think that's irrelevant. (the second obsidian plate in not in my system)

2019-04-26_13 05 33

I can give you more examples as i find them thank you for your work !

rubensworks commented 5 years ago

Interesting, thanks for the info, will look into it.

rubensworks commented 5 years ago

It looks like this was caused by the same problem as in https://github.com/CyclopsMC/IntegratedCrafting/issues/17 when Astral Sorcery was installed. This has been fixed in CommonCapabilities 2.2.1.

Fedwick commented 5 years ago

I installed CommonCapabilities 2.2.1 thanks for the fix ! i also found out that autocomplete isn't working with a bound orb from blood magic even after the fix . (very minor issue but everybody is using bound orbs) anyway if you keep an unbound orb in your system autocomplete works !

unbound orb 2019-05-04_01 57 23

bound orb, my name is in the nbt + numbers ? 2019-05-04_01 57 32

binding nbt tag 2019-05-04_02 39 44

id nbt tag 2019-05-04_02 51 16

If i find any items from any other mods that don't autocomplete i will let you know ! sorry if this is re-opening the issue.

rubensworks commented 5 years ago

Hmm, that won't be an easy one to fix. Will look into it later.

rubensworks commented 5 years ago

@Fedwick I just thought of something that may already be able to fix your issue.

Could you try adding the following entry into the CommonCapabilities config file entry for ignoreNbtPathsForEqualityFilters: "$.binding" ?

If this solves your problem, I can add it to the default config.

Fedwick commented 5 years ago

it works !

would it be possible to make a config like that to ignore item damage ? it would help with recipes from IC2 with items that require energy i think. they auto complete only when full.

rubensworks commented 5 years ago

Note to self: add this to the default config.

@Fedwick The item damage thing would be a completely different thing that would require quite some work, could you create a separate issue for that?