CyclopsMC / IntegratedTerminals

Terminals for managing and overviewing Integrated Dynamics networks
MIT License
5 stars 6 forks source link

3x3 Crafting input items not consumed if holding an item transfer request item #65

Closed VT-14 closed 3 years ago

VT-14 commented 3 years ago

Issue type:


Short description:

In the Storage Terminal's Crafting Page; If you are holding an item transfer request 'item', then crafting something using the built in crafting grid will cancel the item transfer request (just not move it anywhere), and give you the resulting item from the crafting recipe, but not consume the recipe's input items.

Additionally, with my normal display settings the ? button for JEI's auto-fill happens to be over the Terminal's inventory, and I automatically pick one of those transfer request items up almost every time I go to craft something from JEI, making this effective dupe bug really easy to do by accident.

Steps to reproduce the problem:

  1. On a Storage Terminal's Crafting Page, set a recipe.
  2. Pick up anything from the Storage Terminal's storage area to start an item transfer request. Do not put it in your inventory.
  3. While holding that transfer request item, attempt to pick up the crafting output item.
  4. Observe the transfer request item remain in the Terminal's storage area, you are now holding the recipe's output item as a normal item, and the recipe inputs are still in the Terminal's crafting grid.

Video Demo: https://youtu.be/Y5zp6AbWB98

Expected behaviour:


Versions:

Log file:

Debug Crash: https://gist.github.com/VT-14/36169828b50623f2f94a0a8d6ef549e8 latest.log: https://gist.github.com/VT-14/6e53f1b0d81a16b624f694d107923185

rubensworks commented 3 years ago

Thanks for reporting!