search

CyclopsMC / IntegratedTerminals

Terminals for managing and overviewing Integrated Dynamics networks
MIT License
5 stars 6 forks source link

Shift click craft optimization #72

Closed wiwileborne closed 2 years ago

wiwileborne commented 2 years ago

The mass craft lag may be due to FindRecipe because it is executed in a loop at each iteration, when it could be executed only once.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

rubensworks commented 2 years ago

I'm afraid that this may go wrong for certain complex recipes (that consume more than one item per slot).

What mass lag are you referring to btw? Has an issue been reported about this?

In any case, if performance is a problem, there are a bunch of other solutions possible that would also work for complex recipes (such as adding an optional previousRecipe arg to findServerRecipe, which may be checked first).

wiwileborne commented 2 years ago

when the mod performs complex recipes only once the performance is good but when you have a massive storage and you do complex recipes in mass the servers lag

rubensworks commented 2 years ago

Could you open a (performance) issue for this?