CyclopsMC / IntegratedTunnels

Transfer other energy, items and fluids over Integrated Dynamics networks
MIT License
20 stars 13 forks source link

Restore old exact quantity aspect property movement semantics #216

Open rubensworks opened 3 years ago

rubensworks commented 3 years ago

Issue type:


Short description:

Currently, the check stack size property only allows movement of exactly the given quantities (can span across multiple slots). The old exact quantity semantics meant that it only allows movement of exactly the given quantities within a single slot (can NOT span across multiple slots).

Given the niche usage scenario's for exact quantity, I don't consider this feature very urgent.

Originally reported in #215 and handled in 6549b163d534f88048257dfbb3278e4cc5feac27.

rubensworks commented 3 years ago

Thanks for the suggestion!

7eggert commented 3 years ago

The commit is bad. Now it transfers less than the exact quantity, too. Also it removed the option to make exact transfers from all entries even if check stack size was not available.

I think the solution is bad anyway. It should have a max. transfer size and a granularity. E.g. transfer up to 36 items but 9, 18, 27 and 36 are OK.

IntegratedTunnels-1.16.5-1.8.5.jar

rubensworks commented 3 years ago

So the check stacksize option does not work for you?

7eggert commented 3 years ago

On the entries that offer "check stack size" it did work, but most entries did not have that option to begin with.

E.g. "Export all items":

No "check stack size".

I just tested it with a multiservo press (Thermal): Chest → Export Item, card = empty item card, transfer rate = 9, Slot = -1, Check Stack Size = true, Empty is wildcard; rest unchanged.

Put two charcoal into the chest, each being one stack. Both are inside the Multiservo Press.

Test again, Slot = 0: Same.

rubensworks commented 3 years ago

It makes sense that export all items does not have this option, as there is nothing to compare the stack size against.

If you think there is a bug, please open a bug report.