search

CyclopsMC / IntegratedTunnels

Transfer other energy, items and fluids over Integrated Dynamics networks
MIT License
20 stars 13 forks source link

README file has broken link #246

Closed Jack-McKalling closed 2 years ago

Jack-McKalling commented 2 years ago

Issue type:

Short description:

The link to the download page for Lombok plugins is dead. It has an incorrect file extension, currently it is download.htm but it should be download.html.

I found this by trying out various file extensions, and everything but the HTML one gave me a 404. This one just redirects to the correct page (which has no extension, so you could also just remove it altogether).

Steps to reproduce the problem:

  1. Go to https://github.com/CyclopsMC/IntegratedTunnels/blob/master-1.16/README.md
  2. Click the "here" link at the bottom
  3. Notice the 404 page

Expected behaviour:

The link should not give a 404

Versions:

Log file:

rubensworks commented 2 years ago

Thanks for reporting!

rubensworks commented 2 years ago

This change will probably be needed for all Cyclops repos. PRs are welcome.

Jack-McKalling commented 2 years ago

Actually Integrated Dynamics is fine, that's why I reported it here. But some other repos do indeed also have the problem, so I'll see what I can do

Jack-McKalling commented 2 years ago

Oh man this is going to take a while. I have to sign the CLA for all 18 of the affected projects? :(

rubensworks commented 2 years ago

The CLA should be Cyclops organization-wide.

Jack-McKalling commented 2 years ago

There, 18 PRs done. A note however, the following repos didn't require an approval of a maintainer while all others did:

rubensworks commented 2 years ago

Super, thanks a lot! :-)