search

CyclotronResearchCentre / bidsme

Flexible bidsificator for multimodal datasets
GNU General Public License v2.0
8 stars 2 forks source link

JOSS Review — Versioning scheme #9

Closed TheChymera closed 1 year ago

TheChymera commented 1 year ago

As part of the JOSS review: https://github.com/openjournals/joss-reviews/issues/5575

decohost_2023-07-27T00:44:36

I would recommend a versioning scheme that is somewhat cleaner. major.minor.patch is best. While I have seen the post and pre suffixes before, they usually reference a date or some more meaningful information that couldn't otherwise be expressed in the major-minor-patch format. post4 sound like it should have been a patch, i.e. 1.4.4.

Not least of all it causes problems for semantic parsing of the version number.

nbeliy commented 1 year ago

The pre/post are the versioning style of pip, marking post-release (minor patches).

But you are right, will use the 1.4.4 looks nicer. Will adapt for the next release.

nbeliy commented 1 year ago

Hi @TheChymera ,

Updated to conventional schema (1.4.2)

TheChymera commented 1 year ago

That solves the issue.