issues
search
Cyfrin
/
2023-07-escrow
16
stars
12
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
Lack of the input validation to check whether or not the arbiter address would not be `address(0)`, which lead to that both the seller and buyer can not initiate a dispute
#829
codehawks-bot
closed
1 year ago
0
Use > instead of >=
#828
codehawks-bot
closed
1 year ago
1
Use assembly to check for `address(0)`
#827
codehawks-bot
opened
1 year ago
0
Use assembly hashing
#826
codehawks-bot
closed
1 year ago
1
Use assembly to emit events
#825
codehawks-bot
closed
1 year ago
1
Use one method to generate address
#824
codehawks-bot
closed
1 year ago
1
Setting the constructor to payable
#823
codehawks-bot
closed
1 year ago
1
Functions guaranteed to revert when called by normal users can be marked `payable`
#822
codehawks-bot
closed
1 year ago
1
Impact for Arbiter's mind
#821
codehawks-bot
closed
1 year ago
1
Use a more recent version of Solidity
#820
codehawks-bot
closed
1 year ago
1
NatSpec `@param` and `@return` is missing
#819
codehawks-bot
opened
1 year ago
0
Needless `ReentrancyGuard` wastes gas
#818
codehawks-bot
opened
1 year ago
3
Include a fuzz test for arbitrary balances > `price`
#817
codehawks-bot
closed
1 year ago
3
Contract deployment failed with Fee-On-Transfer tokens (like USDT)
#816
codehawks-bot
opened
1 year ago
0
Use calldata instead of memory for function arguments that do not get mutated
#815
codehawks-bot
closed
1 year ago
1
Contracts do not work with fee-on-transfer tokens
#814
codehawks-bot
opened
1 year ago
0
Potential Address Calculation Issue
#813
codehawks-bot
closed
1 year ago
1
No minimum arbiter fee
#812
codehawks-bot
closed
1 year ago
1
Unsafe casting from uint256 to uint160 in computeEscrowAddress
#811
codehawks-bot
closed
1 year ago
1
Due to lack of code to set the state of the `State.Created` to the `s_state` in the Escrow#`constructor()`, the key functions would always be reverted
#810
codehawks-bot
closed
1 year ago
1
The nonReentrant modifier should occur before all other modifiers
#809
codehawks-bot
opened
1 year ago
0
No address(0) check for arbiter
#808
codehawks-bot
closed
1 year ago
1
Use at least Solidity version 0.8.19 to gain some gas boost
#807
codehawks-bot
closed
1 year ago
1
uint comparison with zero can be cheaper
#806
codehawks-bot
opened
1 year ago
0
separated check with if() cost less gas
#805
codehawks-bot
closed
1 year ago
1
Constructors can be marked payable
#804
codehawks-bot
closed
1 year ago
1
Incorrect modifier
#803
codehawks-bot
closed
1 year ago
0
Use assembly to check for `address(0)`
#802
codehawks-bot
opened
1 year ago
0
Transferring tokens directly to stored addresses is problematic for payments
#801
codehawks-bot
opened
1 year ago
0
Use minimal proxies instead of deploying Escrow contract
#800
codehawks-bot
opened
1 year ago
1
Contracts are vulnerable to fee-on-transfer-token-related accounting issues
#799
codehawks-bot
opened
1 year ago
0
Seller can repeatedly DoS resolveDispute.
#798
codehawks-bot
opened
1 year ago
0
balanceOf(address(this)) can be replaced with a constant
#797
codehawks-bot
opened
1 year ago
0
Escrow.sol Contract Is Vulnerable to Permit() Function in DAI Contract
#796
codehawks-bot
closed
1 year ago
2
`computeEscrowAddress` should be internal - Deployment is cheaper for internal functions
#795
codehawks-bot
closed
1 year ago
1
Funds will be locked if buyer or seller get into an accident and there’s no arbiter set because both seller and buyer trust each other
#794
codehawks-bot
opened
1 year ago
0
the emergency receive should be implemented to seller to send seller funds if buyer never response due to some unwished things.
#793
codehawks-bot
opened
1 year ago
0
Use `!= 0` instead of `> 0` for unsigned integer comparison
#792
codehawks-bot
opened
1 year ago
0
Escrow - Lack of set Arbiter function
#791
codehawks-bot
opened
1 year ago
0
Funds will be locked if arbiter dies
#790
codehawks-bot
closed
1 year ago
2
Attacker can make creation of newescrow fail
#789
codehawks-bot
closed
1 year ago
1
Use != 0 instead of > 0 for unsigned integer comparison
#788
codehawks-bot
opened
1 year ago
0
#Escrow - Dispute once initiated can not be cancelled
#787
codehawks-bot
closed
1 year ago
1
Use hardcode address instead address(this)
#786
codehawks-bot
opened
1 year ago
0
Escrow#initiateDispute - does not check if the Escrow is already disputed
#785
codehawks-bot
closed
1 year ago
1
>= costs less gas than >
#784
codehawks-bot
opened
1 year ago
0
Escrow#initiateDispute - Does not check if the escrow Exists or not
#783
codehawks-bot
closed
1 year ago
1
A modifier used only once and not being inherited should be inlined to save gas
#782
codehawks-bot
opened
1 year ago
0
Use nested if and, avoid multiple check combinations
#781
codehawks-bot
opened
1 year ago
0
Multiple calls of token balance
#780
codehawks-bot
closed
1 year ago
1
Previous
Next