Open codehawks-bot opened 1 year ago
getTimeout()
Gas Optimization / Informational
https://github.com/Cyfrin/2023-07-foundry-defi-stablecoin/blob/main/src/libraries/OracleLib.sol#L35
The getTimeout() function in the OracleLib contract is currently marked as public, although it could be marked as external to optimize gas usage.
public
external
Manual review
Consider changing the visibility of the getTimeout() function to external to save gas when the function is called from outside the contract:
function getTimeout(AggregatorV3Interface /* chainlinkFeed */ ) external pure returns (uint256) { return TIMEOUT; }
Unnecessary public visibility in
getTimeout()
Severity
Gas Optimization / Informational
Relevant GitHub Links
https://github.com/Cyfrin/2023-07-foundry-defi-stablecoin/blob/main/src/libraries/OracleLib.sol#L35
Summary
The
getTimeout()
function in the OracleLib contract is currently marked aspublic
, although it could be marked asexternal
to optimize gas usage.Tools Used
Manual review
Recommendations
Consider changing the visibility of the
getTimeout()
function toexternal
to save gas when the function is called from outside the contract: