Open jksgfsdfd opened 1 year ago
L-05 : Precision loss/Rounding to Zero in _distribute()
Issue Link : https://www.codehawks.com/report/cllcnja1h0001lc08z7w0orxx#L-05
Acknowledged not fixed.
The rationale for not choosing to fix provided is: (https://github.com/codefox-inc/sparkn-contracts/issues/26)
1. there will only be several winners with not too small percentages. 2. And if the prize is like 0.01 JPYC, the precision loss is negligible.
If the combination of prize token amount and percentage is taken care of as mentioned, it wouldn't cause an issue.
Issue
L-05 : Precision loss/Rounding to Zero in _distribute()
Issue Link : https://www.codehawks.com/report/cllcnja1h0001lc08z7w0orxx#L-05
Review
Acknowledged not fixed.
The rationale for not choosing to fix provided is: (https://github.com/codefox-inc/sparkn-contracts/issues/26)
If the combination of prize token amount and percentage is taken care of as mentioned, it wouldn't cause an issue.