Cyfrin / Updraft

https://updraft.cyfrin.io
GNU Affero General Public License v3.0
55 stars 39 forks source link

Written lesson cleanup: Smart Contract Lottery #230

Closed gin closed 2 weeks ago

gin commented 3 weeks ago

Fix typos, formatting, and

End of Foundry Fundamentals 🥳 Onwards

EngrPips commented 3 weeks ago

Hello, @gin. Thanks for this contribution, and it will be addressed appropriately as soon as possible

gin commented 2 weeks ago

Yes, absolutely. 👍 Expanding on the comments on the commits:

For video lesson "38. Intro to fuzz testing" (commit https://github.com/Cyfrin/Updraft/commit/4b2178d4c1281607bcd7a126606398af4c64a30f: Update fuzzer's variable name to match video lesson) Screenshot 2024-10-10 at 10 44 22 AM

For video lesson "39. One Big Test" Patrick's solution for the error InvalidRequest() when running forge test --mt testFulfillRandomWordsPicksAWinnerResetsAndSendsMoney is to fund the subscription with more money. He did it by multiplying by 100. (commit https://github.com/Cyfrin/Updraft/commit/cf319b610b180c91d68884e1321d7b7f546ce189: Update failing integration test's solution to match video lesson) Screenshot 2024-10-10 at 10 50 10 AM

Equious commented 2 weeks ago

Thanks for the breakdown, sir. Amazing work.