Open gin opened 1 week ago
Hello, @gin, Thanks for this contribution. This will be attended to appropriately as soon as possible.
Are we removing the details tags because they don't work? @gin I'd love to instead investigate having them fixed if that's the case. There are some lessons later where that tag is hiding a huge number of lines purposefully.
Yes. Thanks for the explanation. I'll revert it. I thought those was some leftover tags that were missed during some Markdown modifications.
Added a commit, and updated 1st post with details about the fix.
commit 2a32a87
In the video lesson, the
depositCollateralAndMintDsc()
function isexternal
. In the written lesson, there is no visibility specifier. This PR addsexternal
to the written lesson.Screenshot showing video lesson and
external
:commit b4c48ba
In the video lesson, the
_redeemCollateral()
function isprivate
. In the written lesson, there is no visibility specifier. This PR addsprivate
to the written lesson, and fix a typo in the variable nametokeAmountFromDebtCovered
totokenAmountFromDebtCovered
(missingn
).