search

Cyfrin / Updraft

https://updraft.cyfrin.io
GNU Affero General Public License v3.0
55 stars 39 forks source link

Advanced Foundry, DeFi Stablecoin: Add missing visibility specifier #241

Open gin opened 1 week ago

gin commented 1 week ago

commit 2a32a87

In the video lesson, the depositCollateralAndMintDsc() function is external. In the written lesson, there is no visibility specifier. This PR adds external to the written lesson.

Screenshot showing video lesson and external: Screenshot 2024-10-22 at 10 57 57 AM

commit b4c48ba

In the video lesson, the _redeemCollateral() function is private. In the written lesson, there is no visibility specifier. This PR adds private to the written lesson, and fix a typo in the variable name tokeAmountFromDebtCovered to tokenAmountFromDebtCovered (missing n). Screenshot 2024-10-24 at 12 45 19 PM

EngrPips commented 1 week ago

Hello, @gin, Thanks for this contribution. This will be attended to appropriately as soon as possible.

Equious commented 1 week ago

Are we removing the details tags because they don't work? @gin I'd love to instead investigate having them fixed if that's the case. There are some lessons later where that tag is hiding a huge number of lines purposefully.

gin commented 1 week ago

Yes. Thanks for the explanation. I'll revert it. I thought those was some leftover tags that were missed during some Markdown modifications.

gin commented 6 days ago

Added a commit, and updated 1st post with details about the fix.