Aderyn Sidebar - Githubissues

Cyfrin / aderyn-vscode

MIT License

1 stars 1 forks source link

Aderyn Sidebar #6

Closed TilakMaddy closed 2 months ago

TilakMaddy commented 4 months ago

Introduces Aderyn in the sidebar (random icon from Microsoft github used as of now)
Allows for scope and exclude input
Aderyn watch button (when clicked displays message "Aderyn is watching your codebase..."

Todo (maybe in this PR or later)

actually invoke aderyn command
persist the state of chosen values of scope and exlcuded for the project in the user's home directory so they don't have to enter it each time.

TilakMaddy commented 4 months ago

Here's where I am confused. I need help

What makes more sense ?

1) aderyn cli takes the responsibility of watching file changes 2) vscode invokes aderyn when there are file changes

Looks like we're already kind of doing option 2, so should we go with it ?

UPDATE:

PR ready: https://github.com/Cyfrin/aderyn/pull/381

I think it's cheaper not to spawn new processes each time and let Aderyn do the watching. :) Also, this way can support file changes that happen externally (outside vscode) can also be supported

TilakMaddy commented 4 months ago

Benefits of having a sidebar:

We can also have sections to show other stuff like attack surface

alexroan commented 3 months ago

Hey @TilakMaddy this is not actually doing anything when I hit the button. It says aderyn is watching, but I get no diagnostic feedback at all.

TilakMaddy commented 3 months ago

Hey @TilakMaddy this is not actually doing anything when I hit the button. It says aderyn is watching, but I get no diagnostic feedback at all.

Alex, you should read PR description : ) Sometimes that also helps 😂

alexroan commented 2 months ago

closing for staleness