search

Cyfrin / aderyn

Aderyn 🦜 Rust-based Solidity AST analyzer.
https://docs.cyfrin.io/
GNU General Public License v2.0
374 stars 53 forks source link

PUSH0 issues raised while hardfork is set to Paris explicitly #547

Open RensR opened 3 months ago

RensR commented 3 months ago

PUSH0 is not supported by all chains

To Reproduce Steps to reproduce the behavior:

  1. Clone repo: https://github.com/smartcontractkit/ccip
  2. Run aderyn with this foundry profile ccip

Expected behavior Since the Paris hardfork is set in foundry.toml I would not expect to see PUSH0 related issues being raised.

alexroan commented 3 months ago

I think the appropriate way to approach this is to accept this as a flag in aderyn, then auto-parse from famous files like foundry.toml or aderyn.toml.

We would then need to build a framework for registering detectors with applicable hardfork versions. Given that this detector is the only one that identifies an issue that changed depending on hardfork version, and node Solidity code, I'm inclined to punt this issue out as "Future Feature", and maybe sunset this detector.