Low Detector: Libraries and contracts should not live in same file

Cyfrin / aderyn

Aderyn 🦜 Rust-based Solidity AST analyzer.

https://docs.cyfrin.io/

GNU General Public License v2.0

416 stars 62 forks source link

Low Detector: Libraries and contracts should not live in same file #735

Closed TilakMaddy closed 2 months ago

TilakMaddy commented 2 months ago

Severity: Low

Qualifications: All versions on solc

Logic: If library contract is seen in a file that has other non-library contracts, we capture the library contract and suggest that it be moved to a different file.

Reason: Library contracts generally need floating pragmas to support a wide variety of contracts. If they are in a file same as contract, then this distinction is hard to support

No assoc. ADE

FOLLOW UP HERE 🙏 #740

TilakMaddy commented 2 months ago

We need flexibility to organize solidity contracts and libraries the way we want (also helps for security scanning and verification)