Cyfrin / foundry-defi-stablecoin-cu

250 stars 117 forks source link

update collateralRedeemEvent to pass proper args #29

Closed pokhrelanmol closed 1 year ago

pokhrelanmol commented 1 year ago

There was a small issue with the way the props were passed to the CollateralRedeemed event.

previous the event looks like event CollateralRedeemed(address indexed redeemedFrom, uint256 indexed amountCollateral, address from, address to); and props passed to this was

emit CollateralRedeemed(from, amountCollateral, from, to);

The updated event is

event CollateralRedeemed(address indexed redeemFrom, address indexed redeemTo, address token, uint256 amount);

and updated props passed is

emit CollateralRedeemed(from, to, tokenCollateralAddress, amountCollateral);

PatrickAlphaC commented 1 year ago

LGTM!