search

Cyfrin / foundry-defi-stablecoin-cu

249 stars 117 forks source link

There is a parameter order issue here that causes the test to pass #53

Closed chengfei867 closed 11 months ago

chengfei867 commented 11 months ago

image The parameters here are the user address first and the token address last. image But when calling here, the order is reversed.

I followed the reverse order in the video and the test results all passed. However, if I use the correct parameter order to test, some tests will fail and the error will be as follows: image

PatrickAlphaC commented 11 months ago

Hello! Thanks for making this issue.

Can you:

  1. Make this a discusson on the full repo? https://github.com/Cyfrin/foundry-full-course-f23/discussions

  2. Could you please remember to follow this section to format your questions? https://youtu.be/umepbfKp5rI?t=22464

chengfei867 commented 11 months ago

Thank you for your prompt response. I will discuss my issue in the discussions section to make it more visible to a wider audience. 谢谢~