search

Cyfrin / foundry-defi-stablecoin-cu

241 stars 107 forks source link

Reentracyguard is now in utils #59

Closed S23Web3 closed 7 months ago

S23Web3 commented 7 months ago

Hi Reentrancy guard moved (I put it without remapping below) in the new openzeppelin 5.0 from import {ReentrancyGuard} from "lib/openzeppelin-contracts/security/utils/ReentrancyGuard.sol"; to import {ReentrancyGuard} from "lib/openzeppelin-contracts/contracts/utils/ReentrancyGuard.sol"; in the DSCEngine.sol i

PatrickAlphaC commented 7 months ago

ah, thanks. Any chance you can open a PR for this?

S23Web3 commented 7 months ago

Good morning, A letter from Caesar! Yes, will do

On Fri, Feb 9, 2024 at 8:51 PM Patrick Collins @.***> wrote:

ah, thanks. Any chance you can open a PR for this?

— Reply to this email directly, view it on GitHub https://github.com/Cyfrin/foundry-defi-stablecoin-f23/issues/59#issuecomment-1936261385, or unsubscribe https://github.com/notifications/unsubscribe-auth/BD3X46IRNYOWL6R77OAPPXLYSZHY3AVCNFSM6AAAAABC5XEQH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZWGI3DCMZYGU . You are receiving this because you authored the thread.Message ID: @.***>

PatrickAlphaC commented 7 months ago

Ah, actually, looks like this is in a newer version of openzeppelin contracts. I'd like to keep the versions here, so I'm closing this.

S23Web3 commented 7 months ago

Aha, thanks makes sense. is there a way in the make to download only the relevant version? Then again, on every lesson when the OZ is installed or make install is executed it needs to be updated. I believe that you recommend 4.6

On Thu, Feb 15, 2024 at 5:16 AM Patrick Collins @.***> wrote:

Ah, actually, looks like this is in a newer version of openzeppelin contracts. I'd like to keep the versions here, so I'm closing this.

— Reply to this email directly, view it on GitHub https://github.com/Cyfrin/foundry-defi-stablecoin-f23/issues/59#issuecomment-1945210509, or unsubscribe https://github.com/notifications/unsubscribe-auth/BD3X46NGT2LQ6LIKCWUQDLLYTVOYXAVCNFSM6AAAAABC5XEQH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBVGIYTANJQHE . You are receiving this because you authored the thread.Message ID: @.***>

PatrickAlphaC commented 7 months ago

Yes!

forge install openzeppelin/openzeppelin-contracts@v4.8.3 --no-commit

You can see this in the Makefile as well.

S23Web3 commented 7 months ago

Awesome, thanks! Maybe would it be possible to add it to the video's? I checked both YT and Updraft on the times where it is mentioned vocally but not written (As when you write "This code will be in the Cyfrin/") I know it might be some work and am willing to help out if needed

On Tue, Feb 20, 2024 at 5:56 AM Patrick Collins @.***> wrote:

Yes!

forge install @.*** --no-commit

You can see this in the Makefile as well.

— Reply to this email directly, view it on GitHub https://github.com/Cyfrin/foundry-defi-stablecoin-f23/issues/59#issuecomment-1953366294, or unsubscribe https://github.com/notifications/unsubscribe-auth/BD3X46JFP24DMBCDRT6VOYDYUP7FRAVCNFSM6AAAAABC5XEQH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJTGM3DMMRZGQ . You are receiving this because you authored the thread.Message ID: @.***>

PatrickAlphaC commented 6 months ago

Good idea! Yes! Can you see the Updraft github?

https://github.com/Cyfrin/Updraft/tree/dev

Could you make a PR?

S23Web3 commented 6 months ago

Could you explain what you mean to do with the PR so I can execute it? I see the updraft, am enlisted and at the s&a part of the course.

On Tue, 27 Feb 2024, 06:59 Patrick Collins, @.***> wrote:

Good idea! Yes! Can you see the Updraft github?

https://github.com/Cyfrin/Updraft/tree/dev

Could you make a PR?

— Reply to this email directly, view it on GitHub https://github.com/Cyfrin/foundry-defi-stablecoin-f23/issues/59#issuecomment-1965699802, or unsubscribe https://github.com/notifications/unsubscribe-auth/BD3X46P3ZEXROF55JHMMQODYVVDZ3AVCNFSM6AAAAABC5XEQH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRVGY4TSOBQGI . You are receiving this because you authored the thread.Message ID: @.***>

S23Web3 commented 6 months ago

It mentions that I need to be a collab, or should I write ever comments and tags in one issue?

On Tue, 27 Feb 2024, 06:59 Patrick Collins, @.***> wrote:

Good idea! Yes! Can you see the Updraft github?

https://github.com/Cyfrin/Updraft/tree/dev

Could you make a PR?

— Reply to this email directly, view it on GitHub https://github.com/Cyfrin/foundry-defi-stablecoin-f23/issues/59#issuecomment-1965699802, or unsubscribe https://github.com/notifications/unsubscribe-auth/BD3X46P3ZEXROF55JHMMQODYVVDZ3AVCNFSM6AAAAABC5XEQH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRVGY4TSOBQGI . You are receiving this because you authored the thread.Message ID: @.***>

PatrickAlphaC commented 6 months ago

Ah sorry, a "PR" is a "Pull Request".